Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput: ensure the field doesn’t lose focus when adornment is changed #534

Open
bpierre opened this issue Aug 26, 2019 · 1 comment
Labels

Comments

@bpierre
Copy link
Contributor

bpierre commented Aug 26, 2019

See aragon/client#904 (comment)

@2color
Copy link
Contributor

2color commented Sep 2, 2019

After a closer look at this, this happens when going from no adornment to adornment. I presume it's to do with the wrapping div that we render for the adornment.

https://github.com/aragon/aragon-ui/blob/80e67f2cb10539a448bda4f9880d5f01cbd71cc2/src/components/Input/TextInput.js#L76-L85

I'm not sure how this should be resolved (is it possible to maintain focus if the underlying dom element has changed?).

For now, I've used the opacity css prop to avoid this problem.

@sohkai sohkai added the bug label Jan 2, 2020
@stale stale bot added the abandoned label Jul 1, 2020
@aragon aragon deleted a comment from stale bot Jul 1, 2020
@Evalir Evalir removed the abandoned label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants