Updated Backend url checker to use RFC3986 instead of RFC2396 which was rejecting valid names such as foo_plex.domain.com

Author: arabcoders

src/Backends/Jellyfin/JellyfinManage.php

@@ -37,8 +37,11 @@ public function manage(array $backend, array $opts = []): array
             );
 
             $question->setValidator(function ($answer) {
-                if (!filter_var($answer, FILTER_VALIDATE_URL)) {
-                    throw new RuntimeException('Invalid backend URL was given.');
+                $host = parse_url($answer, PHP_URL_HOST);
+                if (false === is_string($answer)) {
+                    throw new RuntimeException(
+                        'Invalid backend URL was given. Expecting something like http://example.com:8096/'
+                    );
                 }
                 return $answer;
             });

src/Backends/Plex/PlexManage.php

@@ -156,8 +156,11 @@ public function manage(array $backend, array $opts = []): array
             );
 
             $question->setValidator(function ($answer) {
-                if (!filter_var($answer, FILTER_VALIDATE_URL)) {
-                    throw new RuntimeException('Invalid URL was selected/given.');
+                $host = parse_url($answer, PHP_URL_HOST);
+                if (false === is_string($answer)) {
+                    throw new RuntimeException(
+                        'Invalid URL was selected/given. Expecting something like http://plex:32400.'
+                    );
                 }
                 return $answer;
             });

src/Commands/State/BackupCommand.php

@@ -177,7 +177,7 @@ protected function process(InputInterface $input, OutputInterface $output): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || false === filter_var($url, FILTER_VALIDATE_URL)) {
+            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
                 $this->logger->error('SYSTEM: Ignoring [{backend}] because of invalid URL.', [
                     'backend' => $backendName,
                     'url' => $url ?? 'None',

src/Commands/State/ExportCommand.php

@@ -164,7 +164,7 @@ protected function process(InputInterface $input, OutputInterface $output): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || false === filter_var($url, FILTER_VALIDATE_URL)) {
+            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
                 $this->logger->error(
                     sprintf('%s: Backend does not have valid url.', $backendName),
                     ['url' => $url ?? 'None']

src/Commands/State/ImportCommand.php

@@ -298,7 +298,7 @@ protected function process(InputInterface $input, OutputInterface $output): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || false === filter_var($url, FILTER_VALIDATE_URL)) {
+            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
                 $this->logger->error('SYSTEM: Ignoring [{backend}] because of invalid URL.', [
                     'backend' => $backendName,
                     'url' => $url ?? 'None',

src/Commands/State/PushCommand.php

@@ -133,7 +133,7 @@ protected function process(InputInterface $input): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || false === filter_var($url, FILTER_VALIDATE_URL)) {
+            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
                 $this->logger->error('SYSTEM: [{backend}] Invalid url.', [
                     'backend' => $backendName,
                     'url' => $url ?? 'None',