Fixed bug preventing emby/jellyfin from adding new backends. Closes #360

arabcoders · arabcoders · commit 3961fbd2e73f · 2023-11-11T13:31:48.000+03:00
diff --git a/src/Backends/Emby/EmbyClient.php b/src/Backends/Emby/EmbyClient.php
@@ -90,7 +90,7 @@ public function withContext(Context $context): self
                             'token' => $context->backendToken,
                             'app' => Config::get('name') . '/' . static::CLIENT_NAME,
                             'os' => PHP_OS,
-                            'id' => md5($context->backendUser),
+                            'id' => md5(Config::get('name') . '/' . static::CLIENT_NAME . $context->backendUser),
                             'version' => getAppVersion(),
                             'user' => $context->backendUser,
                         ]
diff --git a/src/Backends/Jellyfin/JellyfinClient.php b/src/Backends/Jellyfin/JellyfinClient.php
@@ -105,7 +105,7 @@ public function withContext(Context $context): self
                             'token' => $context->backendToken,
                             'app' => Config::get('name') . '/' . static::CLIENT_NAME,
                             'os' => PHP_OS,
-                            'id' => md5($context->backendUser),
+                            'id' => md5(Config::get('name') . '/' . static::CLIENT_NAME . $context->backendUser),
                             'version' => getAppVersion(),
                             'user' => $context->backendUser,
                         ]
diff --git a/src/Backends/Jellyfin/JellyfinManage.php b/src/Backends/Jellyfin/JellyfinManage.php
@@ -37,8 +37,7 @@ public function manage(array $backend, array $opts = []): array
             );
 
             $question->setValidator(function ($answer) {
-                $host = parse_url($answer, PHP_URL_HOST);
-                if (false === is_string($answer)) {
+                if (false === isValidURL($answer)) {
                     throw new RuntimeException(
                         'Invalid backend URL was given. Expecting something like http://example.com:8096/'
                     );
diff --git a/src/Backends/Plex/PlexManage.php b/src/Backends/Plex/PlexManage.php
@@ -156,8 +156,7 @@ public function manage(array $backend, array $opts = []): array
             );
 
             $question->setValidator(function ($answer) {
-                $host = parse_url($answer, PHP_URL_HOST);
-                if (false === is_string($answer)) {
+                if (false === isValidURL($answer)) {
                     throw new RuntimeException(
                         'Invalid URL was selected/given. Expecting something like http://plex:32400.'
                     );
diff --git a/src/Commands/Config/AddCommand.php b/src/Commands/Config/AddCommand.php
@@ -6,12 +6,15 @@
 
 use App\Command;
 use App\Libs\Routable;
+use RuntimeException;
 use Symfony\Component\Console\Exception\ExceptionInterface;
+use Symfony\Component\Console\Helper\QuestionHelper;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Question\Question;
 
 #[Routable(command: self::ROUTE)]
 final class AddCommand extends Command
@@ -23,7 +26,7 @@ protected function configure(): void
         $this->setName(self::ROUTE)
             ->setDescription('Add new backend.')
             ->addOption('config', 'c', InputOption::VALUE_REQUIRED, 'Use Alternative config file.')
-            ->addArgument('backend', InputArgument::REQUIRED, 'Backend name')
+            ->addArgument('backend', InputArgument::OPTIONAL, 'Backend name', null)
             ->setHelp(
                 r(
                     <<<HELP
@@ -50,6 +53,31 @@ protected function configure(): void
      */
     protected function runCommand(InputInterface $input, OutputInterface $output): int
     {
+        if (function_exists('stream_isatty') && defined('STDERR')) {
+            $tty = stream_isatty(STDERR);
+        } else {
+            $tty = true;
+        }
+
+        if (false === $tty || $input->getOption('no-interaction')) {
+            $output->writeln(
+                r(
+                    <<<ERROR
+
+                    <error>ERROR:</error> This command require <notice>interaction</notice>. For example:
+
+                    {cmd} <cmd>{route}</cmd>
+
+                    ERROR,
+                    [
+                        'cmd' => trim(commandContext()),
+                        'route' => self::ROUTE,
+                    ]
+                )
+            );
+            return self::FAILURE;
+        }
+
         $opts = [
             '--add' => true,
         ];
@@ -61,7 +89,49 @@ protected function runCommand(InputInterface $input, OutputInterface $output): i
             $opts['--' . $option] = $val;
         }
 
-        $opts['backend'] = strtolower($input->getArgument('backend'));
+        $backend = $input->getArgument('backend');
+
+        if (null !== $backend) {
+            $opts['backend'] = strtolower($backend);
+        } else {
+            // -- $backend.token
+            $opts['backend'] = (function () use (&$opts, $input, $output) {
+                $chosen = ag($opts, 'backend');
+
+                $question = new Question(
+                    <<<HELP
+                    <question>What should we be calling this <value>backend</value>?</question>
+                    ------------------
+                    Backend name is used to identify the backend. The backend name must only contains
+                    <value>lower case a-z</value>, <value>0-9</value> and <value>_</value>.
+                    ------------------
+                    <notice>Choose good name to identify your backend. For example, <value>home_plex</value>.</notice>
+                    HELP. PHP_EOL . '> ',
+                    $chosen
+                );
+
+                $question->setValidator(function ($answer) {
+                    if (empty($answer)) {
+                        throw new RuntimeException('Backend Name cannot be empty.');
+                    }
+                    if (!isValidName($answer) || strtolower($answer) !== $answer) {
+                        throw new RuntimeException(
+                            r(
+                                '<error>ERROR:</error> Invalid [<value>{name}</value>] name was given. Only [<value>a-z, 0-9, _</value>] are allowed.',
+                                [
+                                    'name' => $answer
+                                ],
+                            )
+                        );
+                    }
+                    return $answer;
+                });
+
+                return (new QuestionHelper())->ask($input, $output, $question);
+            })();
+            $output->writeln('');
+            $opts['backend'] = strtolower($opts['backend']);
+        }
 
         return $this->getApplication()?->find(ManageCommand::ROUTE)->run(new ArrayInput($opts), $output) ?? 1;
     }
diff --git a/src/Commands/Config/ManageCommand.php b/src/Commands/Config/ManageCommand.php
@@ -70,7 +70,6 @@ protected function runCommand(InputInterface $input, OutputInterface $output, nu
                     [
                         'cmd' => trim(commandContext()),
                         'route' => self::ROUTE,
-                        'backend' => $input->getArgument('backend'),
                     ]
                 )
 
diff --git a/src/Commands/State/BackupCommand.php b/src/Commands/State/BackupCommand.php
@@ -177,7 +177,7 @@ protected function process(InputInterface $input, OutputInterface $output): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
+            if (null === ($url = ag($backend, 'url')) || false === isValidURL($url)) {
                 $this->logger->error('SYSTEM: Ignoring [{backend}] because of invalid URL.', [
                     'backend' => $backendName,
                     'url' => $url ?? 'None',
diff --git a/src/Commands/State/ExportCommand.php b/src/Commands/State/ExportCommand.php
@@ -164,7 +164,7 @@ protected function process(InputInterface $input, OutputInterface $output): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
+            if (null === ($url = ag($backend, 'url')) || false === isValidURL($url)) {
                 $this->logger->error(
                     sprintf('%s: Backend does not have valid url.', $backendName),
                     ['url' => $url ?? 'None']
diff --git a/src/Commands/State/ImportCommand.php b/src/Commands/State/ImportCommand.php
@@ -298,7 +298,7 @@ protected function process(InputInterface $input, OutputInterface $output): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
+            if (null === ($url = ag($backend, 'url')) || false === isValidURL($url)) {
                 $this->logger->error('SYSTEM: Ignoring [{backend}] because of invalid URL.', [
                     'backend' => $backendName,
                     'url' => $url ?? 'None',
diff --git a/src/Commands/State/ProgressCommand.php b/src/Commands/State/ProgressCommand.php
@@ -146,7 +146,7 @@ protected function process(InputInterface $input, OutputInterface $output): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
+            if (null === ($url = ag($backend, 'url')) || false === isValidURL($url)) {
                 $this->logger->error('SYSTEM: [{backend}] Invalid url.', [
                     'backend' => $backendName,
                     'url' => $url ?? 'None',
diff --git a/src/Commands/State/PushCommand.php b/src/Commands/State/PushCommand.php
@@ -133,7 +133,7 @@ protected function process(InputInterface $input): int
                 continue;
             }
 
-            if (null === ($url = ag($backend, 'url')) || true !== is_string(parse_url($url, PHP_URL_HOST))) {
+            if (null === ($url = ag($backend, 'url')) || false === isValidURL($url)) {
                 $this->logger->error('SYSTEM: [{backend}] Invalid url.', [
                     'backend' => $backendName,
                     'url' => $url ?? 'None',
diff --git a/src/Libs/helpers.php b/src/Libs/helpers.php
@@ -842,3 +842,21 @@ function inContainer(): bool
         return false;
     }
 }
+
+if (false === function_exists('isValidURL')) {
+    /**
+     * Validate URL - RFC 3987 (IRI)
+     *
+     * @param string $url
+     *
+     * @return bool
+     */
+    function isValidURL(string $url): bool
+    {
+        // RFC 3987 For absolute IRIs (internationalized):
+        return (bool)@preg_match(
+            '/^[a-z](?:[-a-z0-9\+\.])*:(?:\/\/(?:(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:])*@)?(?:\[(?:(?:(?:[0-9a-f]{1,4}:){6}(?:[0-9a-f]{1,4}:[0-9a-f]{1,4}|(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(?:\.(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3})|::(?:[0-9a-f]{1,4}:){5}(?:[0-9a-f]{1,4}:[0-9a-f]{1,4}|(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(?:\.(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3})|(?:[0-9a-f]{1,4})?::(?:[0-9a-f]{1,4}:){4}(?:[0-9a-f]{1,4}:[0-9a-f]{1,4}|(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(?:\.(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3})|(?:[0-9a-f]{1,4}:[0-9a-f]{1,4})?::(?:[0-9a-f]{1,4}:){3}(?:[0-9a-f]{1,4}:[0-9a-f]{1,4}|(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(?:\.(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3})|(?:(?:[0-9a-f]{1,4}:){0,2}[0-9a-f]{1,4})?::(?:[0-9a-f]{1,4}:){2}(?:[0-9a-f]{1,4}:[0-9a-f]{1,4}|(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(?:\.(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3})|(?:(?:[0-9a-f]{1,4}:){0,3}[0-9a-f]{1,4})?::[0-9a-f]{1,4}:(?:[0-9a-f]{1,4}:[0-9a-f]{1,4}|(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(?:\.(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3})|(?:(?:[0-9a-f]{1,4}:){0,4}[0-9a-f]{1,4})?::(?:[0-9a-f]{1,4}:[0-9a-f]{1,4}|(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(?:\.(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3})|(?:(?:[0-9a-f]{1,4}:){0,5}[0-9a-f]{1,4})?::[0-9a-f]{1,4}|(?:(?:[0-9a-f]{1,4}:){0,6}[0-9a-f]{1,4})?::)|v[0-9a-f]+[-a-z0-9\._~!\$&\'\(\)\*\+,;=:]+)\]|(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(?:\.(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3}|(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=@])*)(?::[0-9]*)?(?:\/(?:(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:@]))*)*|\/(?:(?:(?:(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:@]))+)(?:\/(?:(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:@]))*)*)?|(?:(?:(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:@]))+)(?:\/(?:(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:@]))*)*|(?!(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:@])))(?:\?(?:(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:@])|[\x{E000}-\x{F8FF}\x{F0000}-\x{FFFFD}|\x{100000}-\x{10FFFD}\/\?])*)?(?:\#(?:(?:%[0-9a-f][0-9a-f]|[-a-z0-9\._~\x{A0}-\x{D7FF}\x{F900}-\x{FDCF}\x{FDF0}-\x{FFEF}\x{10000}-\x{1FFFD}\x{20000}-\x{2FFFD}\x{30000}-\x{3FFFD}\x{40000}-\x{4FFFD}\x{50000}-\x{5FFFD}\x{60000}-\x{6FFFD}\x{70000}-\x{7FFFD}\x{80000}-\x{8FFFD}\x{90000}-\x{9FFFD}\x{A0000}-\x{AFFFD}\x{B0000}-\x{BFFFD}\x{C0000}-\x{CFFFD}\x{D0000}-\x{DFFFD}\x{E1000}-\x{EFFFD}!\$&\'\(\)\*\+,;=:@])|[\/\?])*)?$/iu',
+            $url
+        );
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public function withContext(Context $context): self`
`90`	`90`	`'token' => $context->backendToken,`
`91`	`91`	`'app' => Config::get('name') . '/' . static::CLIENT_NAME,`
`92`	`92`	`'os' => PHP_OS,`
`93`		`- 'id' => md5($context->backendUser),`
	`93`	`+ 'id' => md5(Config::get('name') . '/' . static::CLIENT_NAME . $context->backendUser),`
`94`	`94`	`'version' => getAppVersion(),`
`95`	`95`	`'user' => $context->backendUser,`
`96`	`96`	`]`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public function withContext(Context $context): self`
`105`	`105`	`'token' => $context->backendToken,`
`106`	`106`	`'app' => Config::get('name') . '/' . static::CLIENT_NAME,`
`107`	`107`	`'os' => PHP_OS,`
`108`		`- 'id' => md5($context->backendUser),`
	`108`	`+ 'id' => md5(Config::get('name') . '/' . static::CLIENT_NAME . $context->backendUser),`
`109`	`109`	`'version' => getAppVersion(),`
`110`	`110`	`'user' => $context->backendUser,`
`111`	`111`	`]`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,6 @@ protected function runCommand(InputInterface $input, OutputInterface $output, nu`
`70`	`70`	`[`
`71`	`71`	`'cmd' => trim(commandContext()),`
`72`	`72`	`'route' => self::ROUTE,`
`73`		`- 'backend' => $input->getArgument('backend'),`
`74`	`73`	`]`
`75`	`74`	`)`
`76`	`75`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ protected function process(InputInterface $input, OutputInterface $output): int`
`177`	`177`	`continue;`
`178`	`178`	`}`
`179`	`179`
`180`		`- if (null === ($url = ag($backend, 'url')) \|\| true !== is_string(parse_url($url, PHP_URL_HOST))) {`
	`180`	`+ if (null === ($url = ag($backend, 'url')) \|\| false === isValidURL($url)) {`
`181`	`181`	`$this->logger->error('SYSTEM: Ignoring [{backend}] because of invalid URL.', [`
`182`	`182`	`'backend' => $backendName,`
`183`	`183`	`'url' => $url ?? 'None',`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ protected function process(InputInterface $input, OutputInterface $output): int`
`164`	`164`	`continue;`
`165`	`165`	`}`
`166`	`166`
`167`		`- if (null === ($url = ag($backend, 'url')) \|\| true !== is_string(parse_url($url, PHP_URL_HOST))) {`
	`167`	`+ if (null === ($url = ag($backend, 'url')) \|\| false === isValidURL($url)) {`
`168`	`168`	`$this->logger->error(`
`169`	`169`	`sprintf('%s: Backend does not have valid url.', $backendName),`
`170`	`170`	`['url' => $url ?? 'None']`
Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ protected function process(InputInterface $input, OutputInterface $output): int`
`298`	`298`	`continue;`
`299`	`299`	`}`
`300`	`300`
`301`		`- if (null === ($url = ag($backend, 'url')) \|\| true !== is_string(parse_url($url, PHP_URL_HOST))) {`
	`301`	`+ if (null === ($url = ag($backend, 'url')) \|\| false === isValidURL($url)) {`
`302`	`302`	`$this->logger->error('SYSTEM: Ignoring [{backend}] because of invalid URL.', [`
`303`	`303`	`'backend' => $backendName,`
`304`	`304`	`'url' => $url ?? 'None',`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ protected function process(InputInterface $input, OutputInterface $output): int`
`146`	`146`	`continue;`
`147`	`147`	`}`
`148`	`148`
`149`		`- if (null === ($url = ag($backend, 'url')) \|\| true !== is_string(parse_url($url, PHP_URL_HOST))) {`
	`149`	`+ if (null === ($url = ag($backend, 'url')) \|\| false === isValidURL($url)) {`
`150`	`150`	`$this->logger->error('SYSTEM: [{backend}] Invalid url.', [`
`151`	`151`	`'backend' => $backendName,`
`152`	`152`	`'url' => $url ?? 'None',`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ protected function process(InputInterface $input): int`
`133`	`133`	`continue;`
`134`	`134`	`}`
`135`	`135`
`136`		`- if (null === ($url = ag($backend, 'url')) \|\| true !== is_string(parse_url($url, PHP_URL_HOST))) {`
	`136`	`+ if (null === ($url = ag($backend, 'url')) \|\| false === isValidURL($url)) {`
`137`	`137`	`$this->logger->error('SYSTEM: [{backend}] Invalid url.', [`
`138`	`138`	`'backend' => $backendName,`
`139`	`139`	`'url' => $url ?? 'None',`