M680X - remove unused s_cpu_type#1695
Merged
aquynh merged 1 commit intocapstone-engine:nextfrom Oct 29, 2020
Merged
Conversation
Contributor
Author
|
@aquynh @catenacyber please take a look |
Collaborator
|
@aladur please ack. |
Contributor
|
s_cpu_type is not used and can be removed, commit is fine. |
Collaborator
|
merged, thanks! |
Contributor
|
Always good to remove code :-) |
kabeor
added a commit
that referenced
this pull request
Dec 2, 2021
M680X - remove unused s_cpu_type (#1695)
kazarmy
pushed a commit
to rizinorg/capstone
that referenced
this pull request
Dec 2, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you compile capstone with
-Werrorwarning enabled it produces the following error:Since
s_cpu_typeis not used anywhere in thenextbranch, it's safe to just remove it completely. It was used in themasterbranch only, albeit also unnecessary.cc @trufae @ret2libc