feat(kubernetes): add option to specify kubeconfig file path #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsh
requested review from
josedonizetti,
chen-keinan and
knqyf263
as code owners
|
@mgsh This looks good. Though let's wait until we merge the PR on trivy-kubernetes to update the dependencies and review this one. k? |
mgsh
force-pushed
the
feature/support-kubeconfig2
branch
from
a392f7c
to
54d3798
Compare
go.mod
Outdated
| @@ -321,3 +321,6 @@ replace github.com/docker/docker => github.com/docker/docker v20.10.3-0.20220224 | |||
| // v1.2.0 is taken from github.com/open-policy-agent/opa v0.42.0 | |||
| // v1.2.0 incompatible with github.com/docker/docker v20.10.3-0.20220224222438-c78f6963a1c0+incompatible | |||
| replace oras.land/oras-go => oras.land/oras-go v1.1.1 | |||
|
|
|||
| // TODO: once the change is merged to aquasecurity/trivy-kubernetes, this can be removed and go.sum updated | |||
| replace github.com/aquasecurity/trivy-kubernetes => github.com/mgsh/trivy-kubernetes v0.3.1-0.20220727104021-cd78e50c591a | |||
There was a problem hiding this comment.
The PR was merged on trivy-kubernetes, can we fix the replace here?
mgsh
force-pushed
the
feature/support-kubeconfig2
branch
from
54d3798
to
c6f350f
Compare
|
hi @josedonizetti, I've removed the mod replace change. Please review and merge when you get a chance. |
|
@josedonizetti Can we merge it? |
josedonizetti
approved these changes
Aug 4, 2022
|
@knqyf263 can you review and merge? Thank you! |
knqyf263
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Related PRs
Checklist