Add gitlab.com/graphviz/graphviz

[sebdanielsson]

Check List

• Read CONTRIBUTING.md
  • Read OSS Contribution Guide
• All commits are signed
  • This repository enables Require signed commits, so all commits must be signed
• Avoid force push
• Install and execute the package and confirm if the package works well
• Execute cmdx s to scaffold code

Add Graphviz for Windows x64 and macOS arm64. Linux is not distributed as static binaries.

Summary by CodeRabbit

• New Features
  • Graphviz is now available in package management with versions 14.1.3 and 13.1.2
  • Full platform support for macOS (ARM64) and Windows (AMD64) environments
  • Complete Graphviz toolset included with all binaries and utilities
  • Security features including automatic integrity verification for downloads
  • Graphviz packages added to the registry for easy installation and updates

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a new HTTP-based Graphviz dot package entry and manifests, including two declared versions and platform-specific version_overrides for Darwin and Windows with explicit file mappings and SHA-256 checksum validators. No deletions; only additions to registry and package manifests.

Changes

Cohort / File(s)	Summary
Root registry registry.yaml	Adds a new package override for Graphviz dot: name, http type/link, description, version_constraint:false, and top-level version_overrides.
Graphviz package manifests pkgs/gitlab.com/graphviz/graphviz/pkg.yaml, pkgs/gitlab.com/graphviz/graphviz/registry.yaml	New pkg.yaml listing versions (13.1.2, 14.1.3) and a detailed registry.yaml adding semver-based no_asset override, Darwin and Windows ZIP assets, extensive file->bin mappings for many Graphviz tools, supported_envs entries, and sha256 checksum entries using regexp patterns.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor: fix lint errors #50398: Adds similar registry manifest patterns with top-level version_overrides, no_asset entries, and platform-specific asset/checksum overrides.

Poem

🐰 I hopped in the repo light,
I found dot binaries taking flight,
Darwin and Windows dressed so neat,
Checksums hum a steady beat,
Hooray — graphs bloom overnight! 🎨✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description completes the repository's checklist and provides context about platform support (Windows x64, macOS arm64, no Linux static binaries), meeting the template requirements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'Add gitlab.com/graphviz/graphviz' directly and clearly summarizes the main change: adding a new Graphviz package to the registry.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

registry.yaml (1)

38911-38915: Verify Darwin asset URL and path stability across versions.

The Darwin URL contains a hardcoded OS version (Darwin_23.6.0) which could break if Graphviz changes their naming convention in future releases. The archive structure (Graphviz-{{.Version}}-Darwin/bin/dot) is consistent across versions and the URLs are currently accessible for both minimum (13.1.2) and recent (14.1.3) versions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@registry.yaml` around lines 38911 - 38915, The URL hardcodes an OS version
string ("Darwin_23.6.0") which may break future releases; update the url
template (the line with url:) to remove or generalize that hardcoded OS segment
so it relies only on {{.Version}} (or a stable OS token), keeping the archive
path referenced by files.src ("Graphviz-{{.Version}}-Darwin/bin/dot") unchanged;
ensure the resulting URL pattern still resolves for existing versions and
matches the package host's naming convention used for Darwin builds.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@registry.yaml`:
- Around line 38911-38915: The URL hardcodes an OS version string
("Darwin_23.6.0") which may break future releases; update the url template (the
line with url:) to remove or generalize that hardcoded OS segment so it relies
only on {{.Version}} (or a stable OS token), keeping the archive path referenced
by files.src ("Graphviz-{{.Version}}-Darwin/bin/dot") unchanged; ensure the
resulting URL pattern still resolves for existing versions and matches the
package host's naming convention used for Darwin builds.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3f48441f-2763-4871-b24d-935ce21bec7e

📥 Commits

Reviewing files that changed from the base of the PR and between 49c22a8 and 7a9b738.

📒 Files selected for processing (3)

• pkgs/gitlab.com/graphviz/graphviz/dot/pkg.yaml
• pkgs/gitlab.com/graphviz/graphviz/dot/registry.yaml
• registry.yaml

[suzuki-shunsuke]

Thank you for your contribution!
I'm not familiar with graphviz at all, but seems like zip files includes not only dot but also various commands.
So I guess the package name should not include /dot.
It should be gitlab.com/graphviz/graphviz.

$ zipinfo Darwin_23.6.0_Graphviz-14.1.3-Darwin.zip 
Archive:  Darwin_23.6.0_Graphviz-14.1.3-Darwin.zip
Zip file size: 2670992 bytes, number of entries: 334
drwxr-xr-x  2.0 unx        0 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/
lrwxr-xr-x  2.0 unx        6 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/dot2gxl
-rwxr-xr-x  2.0 unx   487384 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/cluster
-rwxr-xr-x  2.0 unx    69816 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gv2gml
lrwxr-xr-x  2.0 unx        6 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gxl2dot
-rwxr-xr-x  2.0 unx   584024 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/mingle
-rwxr-xr-x  2.0 unx    50888 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/tred
-rwxr-xr-x  2.0 unx    50968 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/unflatten
-rwxr-xr-x  2.0 unx   106376 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/mm2gv
-rwxr-xr-x  2.0 unx    34448 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/dot
-rwxr-xr-x  2.0 unx   194488 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gvpack
lrwxr-xr-x  2.0 unx        6 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gv2gxl
lrwxr-xr-x  2.0 unx        3 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/twopi
-rwxr-xr-x  2.0 unx    35624 bX defN 26-Mar-03 14:01 Graphviz-14.1.3-Darwin/bin/diffimg
-rwxr-xr-x  2.0 unx    72168 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/graphml2gv
lrwxr-xr-x  2.0 unx        3 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/patchwork
-rwxr-xr-x  2.0 unx    70744 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/sccmap
-rwxr-xr-x  2.0 unx   504040 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gvmap
lrwxr-xr-x  2.0 unx        3 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/neato
lrwxr-xr-x  2.0 unx        3 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/osage
-rwxr-xr-x  2.0 unx    87896 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gvgen
-rwxr-xr-x  2.0 unx    33544 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gvpr
-rwxr-xr-x  2.0 unx    34160 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/nop
lrwxr-xr-x  2.0 unx        3 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/circo
-rwxr-xr-x  2.0 unx   109176 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gxl2gv
-rwxr-xr-x  2.0 unx   418856 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gvedit
-rwxr-xr-x  2.0 unx    50968 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/acyclic
-rwxr-xr-x  2.0 unx   109352 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gml2gv
lrwxr-xr-x  2.0 unx        3 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/sfdp
-rwxr-xr-x  2.0 unx    69904 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gc
-rwxr-xr-x  2.0 unx    53032 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/dijkstra
-rwxr-xr-x  2.0 unx     2279 bX defN 26-Mar-03 13:54 Graphviz-14.1.3-Darwin/bin/gvmap.sh
-rwxr-xr-x  2.0 unx     3389 bX defN 26-Mar-03 13:54 Graphviz-14.1.3-Darwin/bin/dot_sandbox
-rwxr-xr-x  2.0 unx    68208 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/dot_builtins
-rwxr-xr-x  2.0 unx    53192 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/prune
lrwxr-xr-x  2.0 unx        3 bx stor 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/fdp
-rwxr-xr-x  2.0 unx    71080 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/bcomps
-rwxr-xr-x  2.0 unx    88632 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/ccomps
-rwxr-xr-x  2.0 unx   378680 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/edgepaint
-rwxr-xr-x  2.0 unx     1150 bX defN 26-Mar-03 13:54 Graphviz-14.1.3-Darwin/bin/vimdot
-rwxr-xr-x  2.0 unx    87752 bX defN 26-Mar-03 14:02 Graphviz-14.1.3-Darwin/bin/gvcolor

If releases have several types of assets that aqua can support, the package name should have any suffix to distinguish them, but seems like graphviz has only single type of assets.

https://gitlab.com/graphviz/graphviz/-/releases

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@registry.yaml`:
- Around line 39057-39060: The package name entry currently uses the
non-canonical suffix "gitlab.com/graphviz/graphviz/dot"; update the name to the
canonical package identifier "gitlab.com/graphviz/graphviz" so it matches the
package-level definition and avoids identity conflicts—edit the name field for
the entry that currently reads "gitlab.com/graphviz/graphviz/dot" (leaving type,
link, and description unchanged).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 396f14ca-d1a7-433e-990f-ec76b1863327

📥 Commits

Reviewing files that changed from the base of the PR and between 4393ce3 and 3daccdd.

📒 Files selected for processing (1)

• registry.yaml

[sebdanielsson]

@suzuki-shunsuke should be fixed now :)

[suzuki-shunsuke]

Thank you!