Skip to content

fix: exclude Windows from pre-commit/pre-commit supported_envs#49398

Merged
suzuki-shunsuke merged 2 commits into
aquaproj:mainfrom
altendky:fix/pre-commit-exclude-windows
Feb 26, 2026
Merged

fix: exclude Windows from pre-commit/pre-commit supported_envs#49398
suzuki-shunsuke merged 2 commits into
aquaproj:mainfrom
altendky:fix/pre-commit-exclude-windows

Conversation

@altendky

@altendky altendky commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add supported_envs: [darwin, linux] to both active version_overrides
    for pre-commit/pre-commit

The .pyz asset requires a Python interpreter to run. On Unix this works
via shebang (#!/usr/bin/env python3), but on Windows aqua's exec path
uses CreateProcess which cannot execute non-PE binaries.

This is the same approach used when adding pypa/pipx (#39951), the
only other .pyz package in the registry.

Broader support for Python tools on Windows is tracked in
aquaproj/aqua#2128.

Summary by CodeRabbit

  • Chores
    • Updated package registry configuration to explicitly declare linux and darwin as supported environments across multiple package entries.

The .pyz (Python zipapp) asset is not directly executable on Windows —
aqua calls CreateProcess which requires a PE binary. This matches how
pypa/pipx handles the same situation (aquaproj#39951).

Broader support for Python tools on Windows is tracked in
aquaproj/aqua#2128.
@suzuki-shunsuke

Copy link
Copy Markdown
Member

Thank you.
I don't have windows, but I tested on GitHub Actions Windows Runner (windows-latest).
I could reproduce the issue.

# pre-commit --help
Feb 26 14:09:19.094 INF download and unarchive the package program=aqua version=2.56.7 exe_name=pre-commit package_name=pre-commit/pre-commit package_version=v4.5.1 registry=standard
Feb 26 14:09:19.562 WRN remove a temporary file program=aqua version=2.56.7 exe_name=pre-commit package_name=pre-commit/pre-commit package_version=v4.5.1 registry=standard error="remove C:\\msys64\\tmp\\528767827: The process cannot access the file because it is being used by another process."
Feb 26 14:09:19.801 ERR aqua failed program=aqua version=2.56.7 exe_name=pre-commit package_name=pre-commit/pre-commit package_version=v4.5.1 registry=standard error="it failed to start the process"
# aqua which pre-commit
C:\Users\runneradmin\AppData\Local\aquaproj-aqua\pkgs\github_release\github.com\pre-commit\pre-commit\v4.5.1\pre-commit-4.5.1.pyz\pre-commit-4.5.1.pyz

# head -n 5 "$(aqua which pre-commit)"
#!/usr/bin/env python3
PK쁐[mٯ+        CACHE_KEYnZYhWhS_a_0q2mqWmh6liHL-VSyYv10DqmQn8sAJqpkPK쁐[`
                                                                          __main__.py#!/usr/bin/env python3
from __future__ import annotations

import os.path

@suzuki-shunsuke suzuki-shunsuke added this to the v4.476.1 milestone Feb 26, 2026
@coderabbitai

coderabbitai Bot commented Feb 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e84d57 and 4a05d0d.

📒 Files selected for processing (2)
  • pkgs/pre-commit/pre-commit/registry.yaml
  • registry.yaml

📝 Walkthrough

Walkthrough

The pull request adds supported_envs entries for darwin and linux to version override blocks in the registry configuration file. These additions clarify platform support for package entries without altering existing logic or control flow.

Changes

Cohort / File(s) Summary
Registry Configuration
pkgs/pre-commit/pre-commit/registry.yaml
Added supported_envs attribute entries specifying "darwin" and "linux" platform support to version override blocks, enhancing environment compatibility declarations without modifying existing functionality.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A registry grows strong and wide,
Darwin and Linux side by side,
With platforms declared, clear and bright,
The toolchain config feels so right!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides a clear summary, technical rationale, and references to related issues, but lacks evidence of completing the checklist items required by the template. Complete the required checklist items from CONTRIBUTING.md to confirm adherence to contribution guidelines, commit signing, and testing steps.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: excluding Windows from the supported environments for pre-commit/pre-commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@suzuki-shunsuke suzuki-shunsuke merged commit 38287a3 into aquaproj:main Feb 26, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this to Done in main Feb 26, 2026
@altendky

Copy link
Copy Markdown
Contributor Author

oof, i should have included my failed ci runs. sorry. anyways, thanks!

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 11, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.476.0` → `v4.481.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary>

### [`v4.481.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.481.0)

[Compare Source](aquaproj/aqua-registry@v4.480.0...v4.481.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.481.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.481.0) | <aquaproj/aqua-registry@v4.480.0...v4.481.0>

#### 🎉 New Packages

[#&#8203;50135](aquaproj/aqua-registry#50135) [raaymax/lazytail](https://github.com/raaymax/lazytail): Log viewer for app development [@&#8203;hituzi-no-sippo](https://github.com/hituzi-no-sippo)
[#&#8203;50093](aquaproj/aqua-registry#50093) [stackrox/stackrox/roxctl](https://github.com/stackrox/stackrox) - CLI for StackRox Kubernetes Security Platform [@&#8203;sebdanielsson](https://github.com/sebdanielsson)

#### Improvement

[#&#8203;50136](aquaproj/aqua-registry#50136) hellux/jotdown: Add search words `djot` [@&#8203;hituzi-no-sippo](https://github.com/hituzi-no-sippo)
[#&#8203;50164](aquaproj/aqua-registry#50164) Use preferred signer\_workflow spelling [@&#8203;scop](https://github.com/scop)

#### Fixes

[#&#8203;50085](aquaproj/aqua-registry#50085) mvdan/sh: Starting v3.13.0, no longer includes a sha256sums.txt asset [@&#8203;adilsyed518](https://github.com/adilsyed518)

#### Security

Configure GitHub Immutable Release config by [@&#8203;scop](https://github.com/scop)

[#&#8203;50115](aquaproj/aqua-registry#50115) twpayne/chezmoi
[#&#8203;50114](aquaproj/aqua-registry#50114) suzuki-shunsuke/ghir
[#&#8203;50113](aquaproj/aqua-registry#50113) suzuki-shunsuke/cmdx
[#&#8203;50084](aquaproj/aqua-registry#50084) pnpm/pnpm
[#&#8203;50081](aquaproj/aqua-registry#50081) jdx/usage
[#&#8203;50077](aquaproj/aqua-registry#50077) jdx/mise
[#&#8203;50076](aquaproj/aqua-registry#50076) jdx/hk
[#&#8203;50075](aquaproj/aqua-registry#50075) j178/prek
[#&#8203;50074](aquaproj/aqua-registry#50074) dprint/dprint

### [`v4.480.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.480.0)

[Compare Source](aquaproj/aqua-registry@v4.479.0...v4.480.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.480.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.480.0) | <aquaproj/aqua-registry@v4.479.0...v4.480.0>

#### 🎉 New Packages

[#&#8203;50019](aquaproj/aqua-registry#50019) [betterleaks/betterleaks](https://github.com/betterleaks/betterleaks): A Better Secrets Scanner built for configurability and speed [@&#8203;hituzi-no-sippo](https://github.com/hituzi-no-sippo)

#### Fixes

[#&#8203;50041](aquaproj/aqua-registry#50041) moonrepo/moon: Re-scaffold to support v2.0.0 or later
[#&#8203;50020](aquaproj/aqua-registry#50020) swanysimon/markdownlint-rs: Rename to swanysimon/mdlint

### [`v4.479.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.479.0)

[Compare Source](aquaproj/aqua-registry@v4.478.0...v4.479.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.479.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.479.0) | <aquaproj/aqua-registry@v4.478.0...v4.479.0>

#### 🎉 New Packages

[#&#8203;49988](aquaproj/aqua-registry#49988) [princjef/gomarkdoc](https://github.com/princjef/gomarkdoc): Generate markdown documentation for Go (golang) code
[#&#8203;49970](aquaproj/aqua-registry#49970) [majorcontext/moat](https://github.com/majorcontext/moat) - Run agents in containers with credential injection and full observability [@&#8203;joonas](https://github.com/joonas)
[#&#8203;49969](aquaproj/aqua-registry#49969) [sudorandom/fauxrpc](https://github.com/sudorandom/fauxrpc) - Easily start a fake gRPC/gRPC-Web/Connect/REST server from protobufs [@&#8203;joonas](https://github.com/joonas)
[#&#8203;49947](aquaproj/aqua-registry#49947) [apache/ant](https://github.com/apache/ant) - Apache Ant is a Java library and command-line tool whose mission is to drive processes described in build files as targets and extension points dependent upon each other [@&#8203;chadlwilson](https://github.com/chadlwilson)

### [`v4.478.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.478.0)

[Compare Source](aquaproj/aqua-registry@v4.477.0...v4.478.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.478.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.478.0) | <aquaproj/aqua-registry@v4.477.0...v4.478.0>

#### 🎉 New Packages

[#&#8203;49934](aquaproj/aqua-registry#49934) [suzuki-shunsuke/docfresh](https://github.com/suzuki-shunsuke/docfresh): Make document maintainable, reusable, and testable

#### Security

[#&#8203;49919](aquaproj/aqua-registry#49919) spinel-coop/rv: GitHub artifact attestations config [@&#8203;scop](https://github.com/scop)

#### Fixes

[#&#8203;49892](aquaproj/aqua-registry#49892) Re-scaffold cloudflare/cloudflared

### [`v4.477.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.477.0)

[Compare Source](aquaproj/aqua-registry@v4.476.0...v4.477.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.477.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.477.0) | <aquaproj/aqua-registry@v4.476.0...v4.477.0>

#### 🎉 New Packages

[#&#8203;49856](aquaproj/aqua-registry#49856) [k1LoW/mo](https://github.com/k1LoW/mo): mo is a Markdown viewer that opens .md files in a browser
[#&#8203;49770](aquaproj/aqua-registry#49770) [#&#8203;49791](aquaproj/aqua-registry#49791) [rtk-ai/rtk](https://github.com/rtk-ai/rtk) - CLI proxy that reduces LLM token consumption by 60-90% on common dev commands. Single Rust binary, zero dependencies [@&#8203;NikitaCOEUR](https://github.com/NikitaCOEUR) [@&#8203;TyceHerrman](https://github.com/TyceHerrman)
[#&#8203;49738](aquaproj/aqua-registry#49738) [yashikota/exiftool-go](https://github.com/yashikota/exiftool-go) - Pure Go ExifTool wrapper powered by WebAssembly [@&#8203;yashikota](https://github.com/yashikota)
[#&#8203;49610](aquaproj/aqua-registry#49610) [datadog-labs/pup](https://github.com/datadog-labs/pup) - Give your AI agent a Pup — a CLI companion with 200+ commands across 33+ Datadog products [@&#8203;iwata](https://github.com/iwata)
[#&#8203;49348](aquaproj/aqua-registry#49348) [huseyinbabal/taws](https://github.com/huseyinbabal/taws) - Terminal UI for AWS (taws) - A terminal-based AWS resource viewer and manager [@&#8203;TyceHerrman](https://github.com/TyceHerrman)

#### Security

[#&#8203;49707](aquaproj/aqua-registry#49707) owenlamont/ryl: GitHub artifact attestations config [@&#8203;scop](https://github.com/scop)
[#&#8203;49340](aquaproj/aqua-registry#49340) astral-sh/ruff: GitHub artifact attestations config [@&#8203;scop](https://github.com/scop)
[#&#8203;49344](aquaproj/aqua-registry#49344) rhysd/actionlint: GitHub artifact attestations config [@&#8203;scop](https://github.com/scop)
[#&#8203;49345](aquaproj/aqua-registry#49345) caarlos0/fork-cleaner: GitHub artifact attestations config [@&#8203;scop](https://github.com/scop)
[#&#8203;49418](aquaproj/aqua-registry#49418) block/goose: GitHub artifact attestations config [@&#8203;scop](https://github.com/scop)

#### Fixes

[#&#8203;49398](aquaproj/aqua-registry#49398) pre-commit/pre-commit: Exclude Windows from `supported_envs` [@&#8203;altendky](https://github.com/altendky)
[#&#8203;49613](aquaproj/aqua-registry#49613) Rename kunobi-ninja/kunobi-releases to kunobi-ninja/kunobi [@&#8203;rawmind0](https://github.com/rawmind0)
[#&#8203;49623](aquaproj/aqua-registry#49623) weaviate/weaviate: Remove hidden Unicode whitespace [@&#8203;jamietanna](https://github.com/jamietanna)
[#&#8203;49652](aquaproj/aqua-registry#49652) technicalpickles/envsense: Add linux/arm64 support [@&#8203;technicalpickles](https://github.com/technicalpickles)
[#&#8203;49753](aquaproj/aqua-registry#49753) mozilla/sccache): Support aarch64 [@&#8203;lahabana](https://github.com/lahabana)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My41NS4zIiwidXBkYXRlZEluVmVyIjoiNDMuNjAuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants