Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap.py *still* blows away changes to editable git checkouts #45

Open
qris opened this issue Apr 4, 2014 · 2 comments
Open

bootstrap.py *still* blows away changes to editable git checkouts #45

qris opened this issue Apr 4, 2014 · 2 comments
Labels
Milestone

Comments

@qris
Copy link
Collaborator

qris commented Apr 4, 2014

Add an editable git checkout to your deploy/pip_packages.txt:

-e git+https://github.com/aptivate/cmsbootstrap.git@2ccf433e101ec9e7eef7ccc4a6c16cc8c5eb59f6#egg=cmsbootstrap

Run deploy/bootstrap.py.

Make changes to the editable code, for example:

echo 'test {}' >> django/website/.ve/src/cmsbootstrap/cmsbootstrap/static/sass/cmsbootstrap.scss

Touch pip_packages.txt and run bootstrap again:

touch deploy/pip_packages.txt
deploy/bootstrap.py

Check what happened to your change:

grep test django/website/.ve/src/cmsbootstrap/cmsbootstrap/static/sass/cmsbootstrap.scss

And it's gone!

Silently blowing away changes to an editable repo is not cool.

@foobacca
Copy link
Collaborator

foobacca commented Apr 4, 2014

I guess this must be due to pip. I agree it's not cool and ideally it would be fixed in pip, but as that's not currently the case we could add some code so that bootstrap could check each checkout in .ve/src/ and if git status --porcelain showed any changes we could check if the user wanted to continue.

Also you title this bug report "still blows away" - was there a previous bug report I missed where we thought it was fixed? Or are you referring to the change where we stopped blowing away the entire virtualenv?

@qris
Copy link
Collaborator Author

qris commented Apr 4, 2014

When we had the big debate about using git submodule or pip -e, I expressed a preference for using submodules because they wouldn't be blown away automatically.

I think someone said that was impossible at the time, and I should just use pip -e. It's clearly not impossible.

@decentral1se decentral1se added this to the P1: MUST milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants