docs: typo in database.phtml #289
Conversation
gewenyu99
left a comment
gewenyu99
left a comment
There was a problem hiding this comment.
Hi @SethFalco, because of some existing efforts, we're not taking PRs for the docs repo's readme :)
I really appreciate your catch in databases.phtml! This year, we're generally now taking grammar-related changes as valid Hacktoberfest PRs. We'd love to accept your contribution, but we'd have to label it invalid for Hacktoberfest.
Sorry!
|
Sure, I removed the 2nd commit. No worries regarding Hacktoberfest. I'm not really giving it much attention this year. I was just learning more about Appwrite, and tend to make documentation PRs if I spot issues. |
gewenyu99
left a comment
gewenyu99
left a comment
There was a problem hiding this comment.
Amazing, thank you for this contribution!
Small PRs like this really help us a lot! We tend to skim very fast, when we read our own docs, it's hard to catch a lot of these ourselves. ❤️ ❤️ ❤️ ❤️ ❤️
If you'd like to learn more about Appwrite, make sure you join us on discord, too.
Myself and other maintainers are very active there if you wanna pop by and chat :) It's a great time to try Appwrite!
appwrite.io/discord
|
Thank you so much for the PR 🤩. We're adding the |
|
@christyjacob4 or @TorstenDittmann, would you please merge this when you get a chance? |
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
6 participants
What does this PR do?
In the Databases page, something was poorly worded. ("Unique Index which not allows duplicates.") This just updates the wording, referencing the line above it.
It could have any of the following really if we wanted to keep it true to the original wording.
But I figured rewording it to "Unique Index to disallow duplicates." might've been simpler to match the wording of the previous key description. ("Plain Index to allow queries.")
Test Plan
N/A
Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
I've read it! I'm guessing this is because you're just using a generic issue template from your appwrite/.github, but the instructions here mostly apply to appwrite/appwrite since we're linked to that contribution guide.
They can actually throw someone off if their first contribution is to the appwrite/docs repo. ^-^'
For example, the
compose.jsonfile here does not define alintorformatcommand. Might be worth thinking if this repo should get its own issue template and/or CONTRIBUTING.md?