Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Conversation

@abnegate
Copy link
Member

@abnegate abnegate commented Oct 10, 2022

What does this PR do?

  • Add new APIs category containing
  • Rename REST API category to References
  • Add GraphQL as a (hidden) SDK so it appears in the integration list
  • Add GraphQL references examples
  • Add GraphQL guide examples
  • Add REST references examples

Test Plan

Manual homepage integration

Related PRs and Issues

appwrite/sdk-generator#577
https://github.com/appwrite/homepage/pull/113
appwrite/appwrite#974

Have you read the Contributing Guidelines on issues?

Yes

@abnegate abnegate marked this pull request as ready for review October 16, 2022 22:41
@gewenyu99
Copy link
Contributor

Hi Jake! How much functional overlap is there between the GraphQL API and the REST API?

Will we have GraphQL examples in the generated API docs, too?

I'll review this soon, is there a chance there's a preview branch for Appwrite where I can try the GraphQL API? 😀

@abnegate
Copy link
Member Author

@gewenyu99 This is going to change a bit more before it's ready to review, I'll change it back to a draft.

We will have GraphQL examples 😁 it will be listed as an option in the SDK dropdown.

You can check out the feat-graphql-support branch for a preview, the tests in tests/e2e/Services/GraphQL should give a decent overview and examples of how you can use it until the rest of the docs are sorted 👌

@abnegate abnegate marked this pull request as draft October 20, 2022 03:03
@abnegate
Copy link
Member Author

abnegate commented Oct 20, 2022

Screen Shot 2022-10-26 at 6 48 32 PM

Screen Shot 2022-10-20 at 8 17 27 PM

Screen Shot 2022-10-20 at 8 32 29 PM

Screenshot 2022-10-20 at 20-32-44

Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing I noticed.

If you switch to REST or GraphQL, then select version < 1.2.x, it'll show empty examples.

Can we hide versions <= 1.2.x when we select REST or GraphQL, and/or auto redirect?

eldadfux and others added 10 commits December 26, 2022 10:39
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Hide unavailable options in version select
Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gewenyu99
Copy link
Contributor

Screenshot 2022-12-27 at 9 53 11 AM

Session Limit

@eldadfux eldadfux merged commit 71a9c57 into main Dec 27, 2022
@gewenyu99 gewenyu99 deleted the feat-graphql branch January 3, 2023 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants