This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Fixed broken bold tags in storage.phtml #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
suggested changes
Sep 27, 2022
Contributor
There was a problem hiding this comment.
@gewenyu99, while you're here, want to fix `File` in Create File? 😬
Contributor
Author
|
@stnguyen90 I added a fix for the ``` Here's a question for you. We don't have inline monospace, do you think we can introduce something quickly so we can start using it to replace all other instances where we use ``` for code related stuff? What alternative formatting do you suggest? |
stnguyen90
approved these changes
Sep 28, 2022
Contributor
|
@gewenyu99, I thought we were using the tag component to format code. Otherwise, we probably need to talk to Elad and Sara on this. The current problem is: which overrides all font to be Poppins rather than a monospace font. For example,
|
Contributor
Author
|
@stnguyen90 The tag is really hard to read, I've seen some complaints :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Found a styling error in the storage docs that should be fixed real quick :)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)