-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 Documentation: Upgrade Instructions Unclear #2616
Comments
Created a PR here: https://github.com/appwrite/docs/pull/133/files I hope it makes things more clear. |
I like this change. @eldadfux, what are your thoughts on adding examples to show that |
@stnguyen90 did you had any snippet in mind? |
The user probably wanted to see something like this: /path/to/parent/of/appwrite $ docker run -it --rm \
--volume /var/run/docker.sock:/var/run/docker.sock \
--volume "$(pwd)"/appwrite:/usr/src/code/appwrite:rw \
--entrypoint="install" \
appwrite/appwrite:0.12.1 but this doesn't match the convention of any of the other example commands so I don't think this should be done. Perhaps the docs could be updated to:
Otherwise, the one-liner can check for the appwrite folder before installing:
|
After talking internally, we decided to create a separate upgrade command that would validate the existing installation before proceeding. It could even check to ensure you're upgrading to the next version of Appwrite rather than skipping versions. |
Related PRs: |
💭 Description
Despite the Upgrade docs saying:
I had 2 instances today where people had confusion about where to run the upgrade command.
basatS7T said:
godfather said:
basatS7T suggested to include example paths to help clarify.
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: