From 85d5ba9b5e20708a9d45ee1e79a4eea72e804a06 Mon Sep 17 00:00:00 2001
From: Ankita Kinger <ankita@appsmith.com>
Date: Fri, 25 Apr 2025 16:07:05 +0530
Subject: [PATCH] updating type for Action run behavior

---
 app/client/src/actions/pluginActionActions.ts               | 6 +++---
 app/client/src/api/PageApi.tsx                              | 4 ++--
 .../src/ce/reducers/entityReducers/actionsReducer.tsx       | 4 ++--
 .../src/ce/reducers/entityReducers/jsActionsReducer.tsx     | 6 +++---
 .../src/pages/Editor/JSEditor/JSEditorToolbar/types.ts      | 3 ++-
 5 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/app/client/src/actions/pluginActionActions.ts b/app/client/src/actions/pluginActionActions.ts
index 98fd6425378c..4f06d7171053 100644
--- a/app/client/src/actions/pluginActionActions.ts
+++ b/app/client/src/actions/pluginActionActions.ts
@@ -20,7 +20,7 @@ import type { EventLocation } from "ee/utils/analyticsUtilTypes";
 import type { GenerateDestinationIdInfoReturnType } from "ee/sagas/helpers";
 import type { Span } from "instrumentation/types";
 import type { EvaluationReduxAction } from "./EvaluationReduxActionTypes";
-import type { ActionRunBehaviour } from "PluginActionEditor/constants/PluginActionConstants";
+import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";
 
 export const createActionRequest = (
   payload: Partial<Action>,
@@ -354,7 +354,7 @@ export const executePageLoadActions = (
 
 export const setActionsRunBehavior = (
   actions: Array<{
-    runBehavior: ActionRunBehaviour;
+    runBehavior: ActionRunBehaviourType;
     id: string;
     name: string;
   }>,
@@ -367,7 +367,7 @@ export const setActionsRunBehavior = (
 
 export const setJSActionsRunBehavior = (
   actions: Array<{
-    runBehavior: ActionRunBehaviour;
+    runBehavior: ActionRunBehaviourType;
     id: string;
     name: string;
     collectionId?: string;
diff --git a/app/client/src/api/PageApi.tsx b/app/client/src/api/PageApi.tsx
index ae05cd00af62..d233da57345a 100644
--- a/app/client/src/api/PageApi.tsx
+++ b/app/client/src/api/PageApi.tsx
@@ -9,7 +9,7 @@ import type {
 import type { DSLWidget } from "WidgetProvider/constants";
 import type { FetchApplicationResponse } from "ee/api/ApplicationApi";
 import type { APP_MODE } from "entities/App";
-import type { ActionRunBehaviour } from "PluginActionEditor/constants/PluginActionConstants";
+import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";
 
 export interface FetchPageRequest {
   pageId: string;
@@ -70,7 +70,7 @@ export interface SavePageResponseData {
   dsl: Partial<DSLWidget>;
   messages: string[];
   actionUpdates: Array<{
-    runBehavior: ActionRunBehaviour;
+    runBehavior: ActionRunBehaviourType;
     id: string;
     name: string;
     collectionId?: string;
diff --git a/app/client/src/ce/reducers/entityReducers/actionsReducer.tsx b/app/client/src/ce/reducers/entityReducers/actionsReducer.tsx
index 87b686bdc0b1..2f7937d72384 100644
--- a/app/client/src/ce/reducers/entityReducers/actionsReducer.tsx
+++ b/app/client/src/ce/reducers/entityReducers/actionsReducer.tsx
@@ -13,7 +13,7 @@ import type {
   UpdateActionPropertyActionPayload,
 } from "actions/pluginActionActions";
 import { klona } from "klona";
-import type { ActionRunBehaviour } from "PluginActionEditor/constants/PluginActionConstants";
+import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";
 
 export interface ActionData {
   isLoading: boolean;
@@ -315,7 +315,7 @@ export const handlers = {
     draftMetaState: ActionDataState,
     action: ReduxAction<
       Array<{
-        runBehavior: ActionRunBehaviour;
+        runBehavior: ActionRunBehaviourType;
         id: string;
         name: string;
       }>
diff --git a/app/client/src/ce/reducers/entityReducers/jsActionsReducer.tsx b/app/client/src/ce/reducers/entityReducers/jsActionsReducer.tsx
index 326532256a79..9ff70ca5430d 100644
--- a/app/client/src/ce/reducers/entityReducers/jsActionsReducer.tsx
+++ b/app/client/src/ce/reducers/entityReducers/jsActionsReducer.tsx
@@ -8,7 +8,7 @@ import {
 import { set, keyBy, findIndex, unset } from "lodash";
 import { create } from "mutative";
 import { klona } from "klona";
-import type { ActionRunBehaviour } from "PluginActionEditor/constants/PluginActionConstants";
+import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";
 
 export const initialState: JSCollectionDataState = [];
 
@@ -366,7 +366,7 @@ export const handlers = {
     action: ReduxAction<{
       actionId: string;
       collectionId: string;
-      runBehavior: ActionRunBehaviour;
+      runBehavior: ActionRunBehaviourType;
     }>,
   ): JSCollectionDataState =>
     state.map((a) => {
@@ -394,7 +394,7 @@ export const handlers = {
     state: JSCollectionDataState,
     action: ReduxAction<
       Array<{
-        runBehavior: ActionRunBehaviour;
+        runBehavior: ActionRunBehaviourType;
         id: string;
         name: string;
         collectionId: string;
diff --git a/app/client/src/pages/Editor/JSEditor/JSEditorToolbar/types.ts b/app/client/src/pages/Editor/JSEditor/JSEditorToolbar/types.ts
index 5f5e5c692058..6375ce761233 100644
--- a/app/client/src/pages/Editor/JSEditor/JSEditorToolbar/types.ts
+++ b/app/client/src/pages/Editor/JSEditor/JSEditorToolbar/types.ts
@@ -1,8 +1,9 @@
 import type { JSAction } from "entities/JSCollection";
 import type { DropdownOption } from "@appsmith/ads-old";
+import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";
 
 export interface OnUpdateSettingsProps {
-  value: boolean | number | string;
+  value: ActionRunBehaviourType;
   propertyName: string;
   action: JSAction;
 }