From 1359a895f648b5b6a07a579210dde5c0ec64fb8b Mon Sep 17 00:00:00 2001 From: Rahul Barwal Date: Mon, 24 Mar 2025 13:26:14 +0530 Subject: [PATCH 1/3] fix: Update feature flag name for infinite scroll functionality --- app/client/src/ce/entities/FeatureFlag.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/client/src/ce/entities/FeatureFlag.ts b/app/client/src/ce/entities/FeatureFlag.ts index 13fd0ce62a9d..72f93af2e567 100644 --- a/app/client/src/ce/entities/FeatureFlag.ts +++ b/app/client/src/ce/entities/FeatureFlag.ts @@ -52,7 +52,7 @@ export const FEATURE_FLAG = { release_external_saas_plugins_enabled: "release_external_saas_plugins_enabled", release_tablev2_infinitescroll_enabled: - "release_tablev2_infinitescroll_enabled", + "release-tablev-2-infinitescroll-enabled-false", release_table_custom_sort_function_enabled: "release_table_custom_sort_function_enabled", } as const; From d87873b678ac5f3272963d087668bee088a20d6e Mon Sep 17 00:00:00 2001 From: Rahul Barwal Date: Mon, 24 Mar 2025 13:53:45 +0530 Subject: [PATCH 2/3] fix: Rename feature flag for infinite scroll in table widget --- .../Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts | 2 +- app/client/src/ce/entities/FeatureFlag.ts | 4 ++-- app/client/src/widgets/TableWidgetV2/constants.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts index b3a1d716add6..e8e892cd8f46 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts @@ -9,7 +9,7 @@ describe( function () { before(() => { featureFlagIntercept({ - release_tablev2_infinitescroll_enabled: true, + "release-tablev-2-infinitescroll-enabled-false": true, }); // Set up a table with test data diff --git a/app/client/src/ce/entities/FeatureFlag.ts b/app/client/src/ce/entities/FeatureFlag.ts index 72f93af2e567..7a3fe088fda7 100644 --- a/app/client/src/ce/entities/FeatureFlag.ts +++ b/app/client/src/ce/entities/FeatureFlag.ts @@ -51,7 +51,7 @@ export const FEATURE_FLAG = { release_ads_entity_item_enabled: "release_ads_entity_item_enabled", release_external_saas_plugins_enabled: "release_external_saas_plugins_enabled", - release_tablev2_infinitescroll_enabled: + "release-tablev-2-infinitescroll-enabled-false": "release-tablev-2-infinitescroll-enabled-false", release_table_custom_sort_function_enabled: "release_table_custom_sort_function_enabled", @@ -98,7 +98,7 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = { config_mask_session_recordings_enabled: true, release_ads_entity_item_enabled: false, release_external_saas_plugins_enabled: false, - release_tablev2_infinitescroll_enabled: false, + "release-tablev-2-infinitescroll-enabled-false": false, release_table_custom_sort_function_enabled: false, }; diff --git a/app/client/src/widgets/TableWidgetV2/constants.ts b/app/client/src/widgets/TableWidgetV2/constants.ts index 345db7c19056..b0bc568f36be 100644 --- a/app/client/src/widgets/TableWidgetV2/constants.ts +++ b/app/client/src/widgets/TableWidgetV2/constants.ts @@ -247,7 +247,7 @@ export const ALLOW_TABLE_WIDGET_SERVER_SIDE_FILTERING = FEATURE_FLAG["release_table_serverside_filtering_enabled"]; export const INFINITE_SCROLL_ENABLED = - FEATURE_FLAG["release_tablev2_infinitescroll_enabled"]; + FEATURE_FLAG["release-tablev-2-infinitescroll-enabled-false"]; export const CUSTOM_SORT_FUNCTION_ENABLED = FEATURE_FLAG["release_table_custom_sort_function_enabled"]; From d5066aa18398179fb433f7d49a549b9e93d9d527 Mon Sep 17 00:00:00 2001 From: Rahul Barwal Date: Mon, 24 Mar 2025 16:09:07 +0530 Subject: [PATCH 3/3] fix: Update feature flag naming for infinite scroll functionality --- .../Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts | 2 +- app/client/src/ce/entities/FeatureFlag.ts | 5 ++--- app/client/src/widgets/TableWidgetV2/constants.ts | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts index e8e892cd8f46..571ab70754ea 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts @@ -9,7 +9,7 @@ describe( function () { before(() => { featureFlagIntercept({ - "release-tablev-2-infinitescroll-enabled-false": true, + release_table_infinitescroll_enabled: true, }); // Set up a table with test data diff --git a/app/client/src/ce/entities/FeatureFlag.ts b/app/client/src/ce/entities/FeatureFlag.ts index 7a3fe088fda7..272acce1eafc 100644 --- a/app/client/src/ce/entities/FeatureFlag.ts +++ b/app/client/src/ce/entities/FeatureFlag.ts @@ -51,8 +51,7 @@ export const FEATURE_FLAG = { release_ads_entity_item_enabled: "release_ads_entity_item_enabled", release_external_saas_plugins_enabled: "release_external_saas_plugins_enabled", - "release-tablev-2-infinitescroll-enabled-false": - "release-tablev-2-infinitescroll-enabled-false", + release_table_infinitescroll_enabled: "release_table_infinitescroll_enabled", release_table_custom_sort_function_enabled: "release_table_custom_sort_function_enabled", } as const; @@ -98,7 +97,7 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = { config_mask_session_recordings_enabled: true, release_ads_entity_item_enabled: false, release_external_saas_plugins_enabled: false, - "release-tablev-2-infinitescroll-enabled-false": false, + release_table_infinitescroll_enabled: false, release_table_custom_sort_function_enabled: false, }; diff --git a/app/client/src/widgets/TableWidgetV2/constants.ts b/app/client/src/widgets/TableWidgetV2/constants.ts index b0bc568f36be..16d58e6d0861 100644 --- a/app/client/src/widgets/TableWidgetV2/constants.ts +++ b/app/client/src/widgets/TableWidgetV2/constants.ts @@ -247,7 +247,7 @@ export const ALLOW_TABLE_WIDGET_SERVER_SIDE_FILTERING = FEATURE_FLAG["release_table_serverside_filtering_enabled"]; export const INFINITE_SCROLL_ENABLED = - FEATURE_FLAG["release-tablev-2-infinitescroll-enabled-false"]; + FEATURE_FLAG["release_table_infinitescroll_enabled"]; export const CUSTOM_SORT_FUNCTION_ENABLED = FEATURE_FLAG["release_table_custom_sort_function_enabled"];