From ccc0c3e0f078a5ab9536727fe4b119db575606de Mon Sep 17 00:00:00 2001 From: Ayush Pahwa Date: Thu, 3 Oct 2024 12:49:42 +0530 Subject: [PATCH 1/5] update: workflow types update --- .../src/ce/constants/WorkflowConstants.ts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/app/client/src/ce/constants/WorkflowConstants.ts b/app/client/src/ce/constants/WorkflowConstants.ts index 753854d23a7e..1737df0fd96b 100644 --- a/app/client/src/ce/constants/WorkflowConstants.ts +++ b/app/client/src/ce/constants/WorkflowConstants.ts @@ -2,6 +2,22 @@ import type { EvaluationVersion } from "constants/EvalConstants"; type ID = string; +export interface WorkflowScheduleSpecInterface { + cronExpressions: Array; +} + +export enum WorkflowScheduleState { + ACTIVE = "ACTIVE", + INACTIVE = "INACTIVE", +} + +export interface WorkflowScheduleInterface { + scheduleSpec: WorkflowScheduleSpecInterface; + triggerData: Record; + name: string; + state: WorkflowScheduleState; +} + // Type for the workflow object. export interface Workflow { id: ID; @@ -20,6 +36,7 @@ export interface Workflow { // PR for reference: https://github.com/appsmithorg/appsmith/pull/8796 evaluationVersion: EvaluationVersion; token?: string; + schedules?: Record; } export type WorkflowMetadata = Workflow; From ae0181ec6ed7a9c5d93a0a5d9530449745784956 Mon Sep 17 00:00:00 2001 From: Ayush Pahwa Date: Thu, 3 Oct 2024 14:58:28 +0530 Subject: [PATCH 2/5] update: added timezone to types --- app/client/src/ce/constants/WorkflowConstants.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/app/client/src/ce/constants/WorkflowConstants.ts b/app/client/src/ce/constants/WorkflowConstants.ts index 1737df0fd96b..a7c818203a7f 100644 --- a/app/client/src/ce/constants/WorkflowConstants.ts +++ b/app/client/src/ce/constants/WorkflowConstants.ts @@ -4,6 +4,7 @@ type ID = string; export interface WorkflowScheduleSpecInterface { cronExpressions: Array; + timezone: string; } export enum WorkflowScheduleState { From 4846cd000b59fe0f59db08e4dd30dc09d575e5b3 Mon Sep 17 00:00:00 2001 From: Ayush Pahwa Date: Thu, 3 Oct 2024 14:59:07 +0530 Subject: [PATCH 3/5] update: name for the field for timezone --- app/client/src/ce/constants/WorkflowConstants.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/client/src/ce/constants/WorkflowConstants.ts b/app/client/src/ce/constants/WorkflowConstants.ts index a7c818203a7f..e66ad3f15204 100644 --- a/app/client/src/ce/constants/WorkflowConstants.ts +++ b/app/client/src/ce/constants/WorkflowConstants.ts @@ -4,7 +4,7 @@ type ID = string; export interface WorkflowScheduleSpecInterface { cronExpressions: Array; - timezone: string; + timeZoneName: string; } export enum WorkflowScheduleState { From 4b1dd6686f4207dbae0255b8d0a53463fb85ebe8 Mon Sep 17 00:00:00 2001 From: Ayush Pahwa Date: Thu, 3 Oct 2024 16:18:05 +0530 Subject: [PATCH 4/5] update: added string for know more link --- app/client/src/ce/constants/messages.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/app/client/src/ce/constants/messages.ts b/app/client/src/ce/constants/messages.ts index b9ca94d7ffda..369c084d4873 100644 --- a/app/client/src/ce/constants/messages.ts +++ b/app/client/src/ce/constants/messages.ts @@ -247,6 +247,7 @@ export const FORK_APP = () => `Fork app`; export const SIGN_IN = () => `Sign in`; export const SHARE_APP = () => `Share app`; export const ALL_APPS = () => `All apps`; +export const KNOW_MORE = () => "Know more"; export const EDITOR_HEADER = { saving: () => "Saving", From 47a2d0ff83ec9ba265f8e6e0ca20bbd5f2601d9f Mon Sep 17 00:00:00 2001 From: Ayush Pahwa Date: Thu, 3 Oct 2024 16:33:09 +0530 Subject: [PATCH 5/5] update: remove unnecesary CE change --- .../src/ce/constants/WorkflowConstants.ts | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/app/client/src/ce/constants/WorkflowConstants.ts b/app/client/src/ce/constants/WorkflowConstants.ts index e66ad3f15204..753854d23a7e 100644 --- a/app/client/src/ce/constants/WorkflowConstants.ts +++ b/app/client/src/ce/constants/WorkflowConstants.ts @@ -2,23 +2,6 @@ import type { EvaluationVersion } from "constants/EvalConstants"; type ID = string; -export interface WorkflowScheduleSpecInterface { - cronExpressions: Array; - timeZoneName: string; -} - -export enum WorkflowScheduleState { - ACTIVE = "ACTIVE", - INACTIVE = "INACTIVE", -} - -export interface WorkflowScheduleInterface { - scheduleSpec: WorkflowScheduleSpecInterface; - triggerData: Record; - name: string; - state: WorkflowScheduleState; -} - // Type for the workflow object. export interface Workflow { id: ID; @@ -37,7 +20,6 @@ export interface Workflow { // PR for reference: https://github.com/appsmithorg/appsmith/pull/8796 evaluationVersion: EvaluationVersion; token?: string; - schedules?: Record; } export type WorkflowMetadata = Workflow;