diff --git a/app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EmptyCanvas_spec.js b/app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EmptyCanvas_spec.js deleted file mode 100644 index a3d9d72532fe..000000000000 --- a/app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EmptyCanvas_spec.js +++ /dev/null @@ -1,31 +0,0 @@ -import { WIDGET } from "../../../../locators/WidgetLocators"; -import { ObjectsRegistry } from "../../../../support/Objects/Registry"; -import EditorNavigation, { - EntityType, -} from "../../../../support/Pages/EditorNavigation"; -import PageList from "../../../../support/Pages/PageList"; - -const { CommonLocators: locators, EntityExplorer: ee } = ObjectsRegistry; - -describe("Empty canvas ctas", () => { - it("1. Ctas validations", () => { - cy.wait(3000); // for page to load, failing in CI - //Ctas should not be shown in the second page - cy.get(locators._emptyCanvasCta).should("be.visible"); - PageList.AddNewPage(); - cy.get(locators._emptyCanvasCta).should("not.exist"); - EditorNavigation.SelectEntityByName("Page1", EntityType.Page); - - //Ctas should continue to show on refresh - cy.get(locators._emptyCanvasCta).should("be.visible"); - cy.reload(); - cy.get(locators._emptyCanvasCta).should("be.visible"); - - //Hide cta on adding a widget - cy.get(locators._emptyCanvasCta).should("be.visible"); - ee.DragDropWidgetNVerify(WIDGET.BUTTON, 200, 200); - cy.get(locators._emptyCanvasCta).should("not.exist"); - PageList.AddNewPage(); - cy.get(locators._emptyCanvasCta).should("not.exist"); - }); -}); diff --git a/app/client/cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js b/app/client/cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js index d46e558fa916..bc76f3bb8b3a 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js @@ -1,5 +1,6 @@ import homePage from "../../../../locators/HomePage"; import * as _ from "../../../../support/Objects/ObjectsCore"; +import PageList from "../../../../support/Pages/PageList"; describe("Visual regression tests", { tags: ["@tag.Visual"] }, () => { // for any changes in UI, update the screenshot in snapshot folder, to do so: @@ -18,7 +19,7 @@ describe("Visual regression tests", { tags: ["@tag.Visual"] }, () => { cy.get("#root").matchImageSnapshot("apppage"); //Layout validation for Quick page wizard - cy.get("[data-testid='generate-app']").click(); + PageList.AddNewPage(Cypress.env("MESSAGES").GENERATE_PAGE_ACTION_TITLE()); cy.wait(2000); // taking screenshot of generate crud page cy.get("#root").matchImageSnapshot("quickPageWizard"); diff --git a/app/client/cypress/locators/GeneratePage.json b/app/client/cypress/locators/GeneratePage.json index fafd5d1c4be2..e6925eb1e742 100644 --- a/app/client/cypress/locators/GeneratePage.json +++ b/app/client/cypress/locators/GeneratePage.json @@ -1,5 +1,4 @@ { - "generateCRUDPageActionCard": "[data-testid='generate-app']", "selectDatasourceDropdown": "[data-testid=t--datasource-dropdown]", "datasourceDropdownOption": "[data-testid=t--datasource-dropdown-option]", "selectTableDropdown": "[data-testid=t--table-dropdown]", diff --git a/app/client/cypress/support/Pages/HomePage.ts b/app/client/cypress/support/Pages/HomePage.ts index ee55d6323b4e..2ae8b77ff87f 100644 --- a/app/client/cypress/support/Pages/HomePage.ts +++ b/app/client/cypress/support/Pages/HomePage.ts @@ -68,7 +68,6 @@ export class HomePage { _applicationName = ".t--application-name"; private _editAppName = "bp3-editable-text-editing"; private _appMenu = ".ads-v2-menu__menu-item-children"; - _buildFromDataTableActionCard = "[data-testid='generate-app']"; private _selectRole = "//span[text()='Select a role']/ancestor::div"; private _searchInput = "input[type='text']"; _appHoverIcon = (action: string) => ".t--application-" + action + "-link";