Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "override" config source #568

Open
4 tasks
tombruijn opened this issue Jan 27, 2022 · 0 comments
Open
4 tasks

Add "override" config source #568

tombruijn opened this issue Jan 27, 2022 · 0 comments
Labels
enhancement small issue Small issues anyone can close in about an hour.

Comments

@tombruijn
Copy link
Member

As discussed in https://github.com/appsignal/integration-guide/pull/128, we want to track some config options in the "override" source.

TODO

  • Add "override" config source to the Config module
  • Move the backwards compatability logic to be set through the "override" source, rather than after the fact as is done now
    • Move the overrides that are now reported in the "system" to the "override" source
    • Check if this actually applies to any config options for Node.js
  • Update the diagnose report to report the "override" source
  • Update Node.js load order docs page to mention the "override" source https://docs.appsignal.com/nodejs/configuration/load-order.html
@tombruijn tombruijn added the small issue Small issues anyone can close in about an hour. label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement small issue Small issues anyone can close in about an hour.
Projects
None yet
Development

No branches or pull requests

1 participant