Drop support for Node.js 10 and 11 (#432)

tombruijn · web-flow · commit f7acf8396d10 · 2021-08-19T09:43:58.000+02:00
The Node.js team no longer support these versions according to their releases page: https://nodejs.org/en/about/releases/ According to our policy, also drop support for unmaintained versions of a language: https://github.com/appsignal/integration-guide/blob/aaf1c35249effa9da8f8715ae7f7be8641437865/maintain/version-support.md (private link) This will help make maintenance easier as we do not need to support very long versions of Node.js anymore and don't have to add polyfills for missing features and fixes. Both package bumps are a major version, because they are backwards incompatible changes. I've also bumped the version in the `.tool-versions` file used by the asdf language version manager. ## Background I was trying to make a PR work and it didn't work on Node.js 10 and 11 a package used something called `globalThis`, which is only available on Node.js 12 or higher. #421 Then I found out Node.js 10 and 11 are no longer maintained and we can drop support.
diff --git a/.semaphore/semaphore.yml b/.semaphore/semaphore.yml
@@ -444,159 +444,3 @@ blocks:
       commands:
       - script/install_test_example_packages nextjs next@10.2.3 react@16.14.0 react-dom@16.14.0
       - script/test_package_integration nextjs
-- name: Node.js 11 - Build
-  dependencies:
-  - Validation
-  task:
-    env_vars:
-    - name: NODE_VERSION
-      value: '11'
-    prologue:
-      commands:
-      - cache restore
-      - mono bootstrap --ci
-      - cache store
-    jobs:
-    - name: Build
-      commands:
-      - mono build
-      - mono run --package @appsignal/nodejs-ext -- npm run build:ext
-      - cache store $_PACKAGES_CACHE-packages-$SEMAPHORE_GIT_SHA-v$NODE_VERSION packages
-      - cache store $_PACKAGES_CACHE-install-report-$SEMAPHORE_GIT_SHA-v$NODE_VERSION
-        /tmp/appsignal-*-install.report
-- name: Node.js 11 - Tests
-  dependencies:
-  - Node.js 11 - Build
-  task:
-    env_vars:
-    - name: NODE_VERSION
-      value: '11'
-    prologue:
-      commands:
-      - cache restore
-      - cache restore $_PACKAGES_CACHE-packages-$SEMAPHORE_GIT_SHA-v$NODE_VERSION
-      - cache restore $_PACKAGES_CACHE-install-report-$SEMAPHORE_GIT_SHA-v$NODE_VERSION
-      - mono bootstrap --ci
-    jobs:
-    - name: "@appsignal/nodejs - nodejs"
-      commands:
-      - mono test --package=@appsignal/nodejs
-    - name: "@appsignal/nodejs - nodejs - diagnose"
-      commands:
-      - git submodule init
-      - git submodule update
-      - LANGUAGE=nodejs test/integration/diagnose/bin/test
-    - name: "@appsignal/nodejs-ext - nodejs-ext"
-      commands:
-      - mono test --package=@appsignal/nodejs-ext
-      - mono run --package @appsignal/nodejs-ext -- npm run test:failure
-    - name: "@appsignal/express - express@latest - integrations"
-      commands:
-      - script/install_test_example_packages express express@latest
-      - script/test_package_integration express
-    - name: "@appsignal/express - express@4.17.1 - integrations"
-      commands:
-      - script/install_test_example_packages express express@4.17.1
-      - script/test_package_integration express
-    - name: "@appsignal/koa - koa@latest - integrations"
-      commands:
-      - script/install_test_example_packages koa koa@latest
-      - script/test_package_integration koa
-    - name: "@appsignal/koa - koa@2.13.1 - integrations"
-      commands:
-      - script/install_test_example_packages koa koa@2.13.1
-      - script/test_package_integration koa
-    - name: "@appsignal/koa - koa@2.12.1 - integrations"
-      commands:
-      - script/install_test_example_packages koa koa@2.12.1
-      - script/test_package_integration koa
-    - name: "@appsignal/nextjs - next.js@latest - integrations"
-      commands:
-      - script/install_test_example_packages nextjs next@latest react@latest react-dom@latest
-      - script/test_package_integration nextjs
-    - name: "@appsignal/nextjs - next.js@11.0.1 - integrations"
-      commands:
-      - script/install_test_example_packages nextjs next@11.0.1 react@17.0.2 react-dom@17.0.2
-      - script/test_package_integration nextjs
-    - name: "@appsignal/nextjs - next.js@10.2.3 - integrations"
-      commands:
-      - script/install_test_example_packages nextjs next@10.2.3 react@16.14.0 react-dom@16.14.0
-      - script/test_package_integration nextjs
-- name: Node.js 10 - Build
-  dependencies:
-  - Validation
-  task:
-    env_vars:
-    - name: NODE_VERSION
-      value: '10'
-    prologue:
-      commands:
-      - cache restore
-      - mono bootstrap --ci
-      - cache store
-    jobs:
-    - name: Build
-      commands:
-      - mono build
-      - mono run --package @appsignal/nodejs-ext -- npm run build:ext
-      - cache store $_PACKAGES_CACHE-packages-$SEMAPHORE_GIT_SHA-v$NODE_VERSION packages
-      - cache store $_PACKAGES_CACHE-install-report-$SEMAPHORE_GIT_SHA-v$NODE_VERSION
-        /tmp/appsignal-*-install.report
-- name: Node.js 10 - Tests
-  dependencies:
-  - Node.js 10 - Build
-  task:
-    env_vars:
-    - name: NODE_VERSION
-      value: '10'
-    prologue:
-      commands:
-      - cache restore
-      - cache restore $_PACKAGES_CACHE-packages-$SEMAPHORE_GIT_SHA-v$NODE_VERSION
-      - cache restore $_PACKAGES_CACHE-install-report-$SEMAPHORE_GIT_SHA-v$NODE_VERSION
-      - mono bootstrap --ci
-    jobs:
-    - name: "@appsignal/nodejs - nodejs"
-      commands:
-      - mono test --package=@appsignal/nodejs
-    - name: "@appsignal/nodejs - nodejs - diagnose"
-      commands:
-      - git submodule init
-      - git submodule update
-      - LANGUAGE=nodejs test/integration/diagnose/bin/test
-    - name: "@appsignal/nodejs-ext - nodejs-ext"
-      commands:
-      - mono test --package=@appsignal/nodejs-ext
-      - mono run --package @appsignal/nodejs-ext -- npm run test:failure
-    - name: "@appsignal/express - express@latest - integrations"
-      commands:
-      - script/install_test_example_packages express express@latest
-      - script/test_package_integration express
-    - name: "@appsignal/express - express@4.17.1 - integrations"
-      commands:
-      - script/install_test_example_packages express express@4.17.1
-      - script/test_package_integration express
-    - name: "@appsignal/koa - koa@latest - integrations"
-      commands:
-      - script/install_test_example_packages koa koa@latest
-      - script/test_package_integration koa
-    - name: "@appsignal/koa - koa@2.13.1 - integrations"
-      commands:
-      - script/install_test_example_packages koa koa@2.13.1
-      - script/test_package_integration koa
-    - name: "@appsignal/koa - koa@2.12.1 - integrations"
-      commands:
-      - script/install_test_example_packages koa koa@2.12.1
-      - script/test_package_integration koa
-    - name: "@appsignal/nextjs - next.js@latest - integrations"
-      commands:
-      - script/install_test_example_packages nextjs next@latest react@latest react-dom@latest
-      - script/test_package_integration nextjs
-    - name: "@appsignal/nextjs - next.js@11.0.1 - integrations"
-      commands:
-      - script/install_test_example_packages nextjs next@11.0.1 react@17.0.2 react-dom@17.0.2
-      - script/test_package_integration nextjs
-    - name: "@appsignal/nextjs - next.js@10.2.3 - integrations"
-      commands:
-      - script/install_test_example_packages nextjs next@10.2.3 react@16.14.0 react-dom@16.14.0
-      - script/test_package_integration nextjs
diff --git a/.tool-versions b/.tool-versions
@@ -1 +1 @@
-nodejs 10.24.1
+nodejs 12.22.5
diff --git a/build_matrix.yml b/build_matrix.yml
@@ -62,8 +62,6 @@ matrix:
     - nodejs: "14"
     - nodejs: "13"
     - nodejs: "12"
-    - nodejs: "11"
-    - nodejs: "10"
   packages:
     - package: "@appsignal/nodejs"
       path: "packages/nodejs"
diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   "main": "dist/index",
   "license": "MIT",
   "engines": {
-    "node": ">= 10",
+    "node": ">= 12",
     "npm": ">= 7"
   },
   "workspaces": [
diff --git a/packages/nodejs-ext/.changesets/drop-node-js-10-and-11-support.md b/packages/nodejs-ext/.changesets/drop-node-js-10-and-11-support.md
@@ -0,0 +1,5 @@
+---
+bump: "major"
+---
+
+Drop support for Node.js 10 and 11. These are unmaintained versions of Node.js.
diff --git a/packages/nodejs-ext/package.json b/packages/nodejs-ext/package.json
@@ -30,7 +30,7 @@
     "x86"
   ],
   "engines": {
-    "node": ">= 10"
+    "node": ">= 12"
   },
   "publishConfig": {
     "access": "public"
diff --git a/packages/nodejs/.changesets/drop-node-js-10-and-11-support.md b/packages/nodejs/.changesets/drop-node-js-10-and-11-support.md
@@ -0,0 +1,5 @@
+---
+bump: "major"
+---
+
+Drop support for Node.js 10 and 11. These are unmaintained versions of Node.js.
diff --git a/packages/nodejs/package.json b/packages/nodejs/package.json
@@ -38,7 +38,7 @@
     "version": "npm run versionfile"
   },
   "engines": {
-    "node": ">= 10"
+    "node": ">= 12"
   },
   "publishConfig": {
     "access": "public"
