Skip to content

Commit 4c453cc

Browse files
committed
Merge extension package into core one
The extension package is no longer an independent entity, it is now merged into @appsignal/nodejs. The installation script for the extension no longer aborts `npm install` if something goes wrong during the process. This allows the users to keep running their apps. There's no need to use the script that creates the version file as the extension constants are always available now. So the script has been removed.
1 parent bca89ac commit 4c453cc

34 files changed

+117
-370
lines changed

.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ build/
8181
/ext/libappsignal.dylib
8282

8383
# Agent archives
84-
packages/nodejs-ext/ext/*.tar.gz
84+
packages/nodejs/ext/*.tar.gz
8585

8686
packages/*/test/spec/examples.txt
8787
packages/*/test/example/package-lock.json

.semaphore/semaphore.yml

-16
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,6 @@ blocks:
116116
- git submodule init
117117
- git submodule update
118118
- LANGUAGE=nodejs test/integration/diagnose/bin/test
119-
- name: "@appsignal/nodejs-ext - nodejs-ext"
120-
commands:
121-
- mono test --package=@appsignal/nodejs-ext
122-
- mono run --package @appsignal/nodejs-ext -- npm run test:failure
123119
- name: "@appsignal/apollo-server - apollo-server@latest - integrations"
124120
commands:
125121
- script/install_test_example_packages apollo-server apollo-server-plugin-base@latest
@@ -215,10 +211,6 @@ blocks:
215211
- git submodule init
216212
- git submodule update
217213
- LANGUAGE=nodejs test/integration/diagnose/bin/test
218-
- name: "@appsignal/nodejs-ext - nodejs-ext"
219-
commands:
220-
- mono test --package=@appsignal/nodejs-ext
221-
- mono run --package @appsignal/nodejs-ext -- npm run test:failure
222214
- name: "@appsignal/apollo-server - apollo-server@latest - integrations"
223215
commands:
224216
- script/install_test_example_packages apollo-server apollo-server-plugin-base@latest
@@ -312,10 +304,6 @@ blocks:
312304
- git submodule init
313305
- git submodule update
314306
- LANGUAGE=nodejs test/integration/diagnose/bin/test
315-
- name: "@appsignal/nodejs-ext - nodejs-ext"
316-
commands:
317-
- mono test --package=@appsignal/nodejs-ext
318-
- mono run --package @appsignal/nodejs-ext -- npm run test:failure
319307
- name: "@appsignal/apollo-server - apollo-server@latest - integrations"
320308
commands:
321309
- script/install_test_example_packages apollo-server apollo-server-plugin-base@latest
@@ -409,10 +397,6 @@ blocks:
409397
- git submodule init
410398
- git submodule update
411399
- LANGUAGE=nodejs test/integration/diagnose/bin/test
412-
- name: "@appsignal/nodejs-ext - nodejs-ext"
413-
commands:
414-
- mono test --package=@appsignal/nodejs-ext
415-
- mono run --package @appsignal/nodejs-ext -- npm run test:failure
416400
- name: "@appsignal/apollo-server - apollo-server@latest - integrations"
417401
commands:
418402
- script/install_test_example_packages apollo-server apollo-server-plugin-base@latest

package-lock.json

+67-61
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"bootstrap:ci": "echo Please run 'mono bootstrap --ci' instead.",
2929
"build": "echo Please run 'mono build' instead.",
3030
"build:watch": "echo Please run 'mono run npm run build:watch --parallel' instead.",
31-
"build:ext": "echo Please run 'mono run npm run build:ext --package @appsignal/nodejs-ext' instead.",
3231
"clean": "echo Please run 'mono clean' instead.",
3332
"test": "echo Please run 'mono test' instead.",
3433
"lint": "prettier --check **/*.{js,ts}",

packages/nodejs-ext/.changesets/.gitkeep

Whitespace-only changes.

0 commit comments

Comments
 (0)