Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #958
Type of Change:
音声接続処理の仕様変更
Cause of the Problem (問題の原因)
切断時のハンドラが再接続すべきかどうかの判断を兼ねていましたが, これは再接続できるかもしれない状況で呼び出されるので, 強制切断された際には呼び出されていませんでした.
Dealing with Problems (問題への対処)
そもそも再接続することが好ましくないことが多く, ハンドラに機能を持たせすぎていたので, この再接続を制御する機能を除去し, あらゆる切断された状況でもハンドラが呼び出されるようにしました.
Details of implementation (実施内容)
VoiceConnection
の引数の仕様を変更し, それを利用していたコードの記述を修正しました. そして再接続処理のコードをすべて除去しました.