Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: こるくの玉音放送縮小版を追加 #936

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Aug 4, 2023

Details of implementation (実施内容)

!gyokuon true で縮小版の玉音放送を再生するフラグを追加しました。

@m1sk9 m1sk9 added the C-enhancement Category: enhancement label Aug 4, 2023
@m1sk9 m1sk9 self-assigned this Aug 4, 2023
@m1sk9 m1sk9 changed the title Feat/gyokuon short feat: こるくの玉音放送縮小版を追加 Aug 4, 2023
@m1sk9 m1sk9 requested a review from MikuroXina August 4, 2023 15:09
@m1sk9 m1sk9 removed their assignment Aug 4, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc0bded
Status: ✅  Deploy successful!
Preview URL: https://bdd488bb.oreorebot2.pages.dev
Branch Preview URL: https://feat-gyokuon-short.oreorebot2.pages.dev

View logs

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #936 (fc0bded) into main (a2eee16) will increase coverage by 0.13%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   74.02%   74.16%   +0.13%     
==========================================
  Files          72       72              
  Lines        4897     4915      +18     
  Branches      415      419       +4     
==========================================
+ Hits         3625     3645      +20     
+ Misses        858      852       -6     
- Partials      414      418       +4     
Flag Coverage Δ
unittests 74.16% <91.30%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/service/command/gyokuon.ts 81.81% <91.30%> (+2.80%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@m1sk9 m1sk9 merged commit c25fb4e into main Aug 5, 2023
15 checks passed
@m1sk9 m1sk9 deleted the feat/gyokuon-short branch August 5, 2023 02:16
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants