Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Discord の新ユーザーネームシステムに対応する #915

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Jul 22, 2023

close #914

Type of Change:

新規追加 (既存機能の変更)

Details of implementation (実施内容)

Discord の新ユーザーネームシステムに対応しました。 ( # による識別タグが廃止されたシステム)

  • 新システムに移行済みのユーザーはユーザーネームの最後に #0 が付与された状態で Discord API が応答します。そのため、その #0 を取り除く形で対応しました。
  • 未変更のユーザー、新システム移行が始まっていないBot はまだ識別タグがあるためそのようなユーザー、Botに対して検索を実行した場合識別タグを今まで通り表示します。
  • 埋め込み(Embed)のフィールド名は ユーザーネーム に統一しました。
  • テストケースは識別タグを取り除かないパターン (識別タグがまだあるユーザーに対しての検索)を新しく追加しています。

@m1sk9 m1sk9 added the C-improvement Category: improvement label Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #915 (085a74f) into main (58f56be) will decrease coverage by 0.02%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   74.04%   74.03%   -0.02%     
==========================================
  Files          72       72              
  Lines        4874     4883       +9     
  Branches      408      411       +3     
==========================================
+ Hits         3609     3615       +6     
  Misses        858      858              
- Partials      407      410       +3     
Flag Coverage Δ
unittests 74.03% <76.92%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/command/user-info.ts 84.61% <76.92%> (-1.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/service/command/user-info.test.ts Outdated Show resolved Hide resolved
@m1sk9 m1sk9 merged commit fb76ba9 into main Jul 22, 2023
13 of 14 checks passed
@m1sk9 m1sk9 deleted the fix/replace-username-system branch July 22, 2023 15:20
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-improvement Category: improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord の新しいユーザーネームシステムに対応する
2 participants