Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: コンピューターの天才、9つのC言語を操る のMEMEを追加 #712

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Feb 7, 2023

Type of Change:

新規追加 (MEME)

Details of implementation (実施内容)

!clang GitHub ラベル >> GitHubの天才、9つのラベルを操る

@m1sk9 m1sk9 added the C-enhancement Category: enhancement label Feb 7, 2023
@m1sk9 m1sk9 requested a review from MikuroXina February 7, 2023 16:32
@m1sk9 m1sk9 self-assigned this Feb 7, 2023
@m1sk9 m1sk9 marked this pull request as draft February 7, 2023 16:32
@m1sk9 m1sk9 marked this pull request as ready for review February 7, 2023 16:38
@m1sk9 m1sk9 enabled auto-merge (squash) February 7, 2023 16:38
Copy link
Collaborator

@MikuroXina MikuroXina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コマンド名が clang なのにファイル名や変数名は clang が分かれている扱いになっているので, どちらかに統一してほしいです

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #712 (f003745) into main (5ef5f05) will increase coverage by 0.04%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   72.45%   72.49%   +0.04%     
==========================================
  Files          67       68       +1     
  Lines        4697     4712      +15     
  Branches      443      445       +2     
==========================================
+ Hits         3403     3416      +13     
  Misses        854      854              
- Partials      440      442       +2     
Flag Coverage Δ
unittests 72.49% <87.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/command/meme/clang.ts 84.61% <84.61%> (ø)
src/service/command/meme/index.ts 96.77% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@m1sk9 m1sk9 merged commit 861d42d into main Feb 7, 2023
@m1sk9 m1sk9 deleted the feat/c-lang-meme branch February 7, 2023 17:06
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants