Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ボイスチャンネル関連の機能で成功時にメッセージを送信する #661

Merged
merged 12 commits into from
Jan 19, 2023

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Jan 5, 2023

close #660

Type of Change:

変更

Details of implementation (実施内容)

!gyokuon, !kaere 実行に成功した際のメッセージを追加しました。

響度が足りなかったらRCください、艦これは未履修なのでサジェストのほうが嬉しいです

@m1sk9 m1sk9 added improvement Need more Hibikiness I need more Hibikiness in the message labels Jan 5, 2023
@m1sk9 m1sk9 requested a review from MikuroXina January 5, 2023 10:46
@m1sk9 m1sk9 self-assigned this Jan 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #661 (a3ada41) into main (9329ec9) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   72.30%   72.36%   +0.06%     
==========================================
  Files          66       66              
  Lines        4632     4643      +11     
  Branches      438      437       -1     
==========================================
+ Hits         3349     3360      +11     
- Misses        848      849       +1     
+ Partials      435      434       -1     
Flag Coverage Δ
unittests 72.36% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/command/gyokuon.ts 77.77% <100.00%> (+1.15%) ⬆️
src/service/command/kaere.ts 71.46% <100.00%> (+0.55%) ⬆️
src/service/command/command-message.ts 93.05% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/service/command/kaere.ts Outdated Show resolved Hide resolved
@raiga0310
Copy link
Sponsor Contributor

https://wikiwiki.jp/kancolle/%E9%9F%BF/%E6%99%82%E5%A0%B1%E3%83%9C%E3%82%A4%E3%82%B9
ご参考までにどうぞ(RCのニュアンスは含んでいません)

@m1sk9 m1sk9 enabled auto-merge (squash) January 19, 2023 14:06
src/service/command/kaere.ts Outdated Show resolved Hide resolved
@m1sk9 m1sk9 merged commit 60a9d0a into main Jan 19, 2023
@m1sk9 m1sk9 deleted the feat/sucess-message branch January 19, 2023 14:32
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need more Hibikiness I need more Hibikiness in the message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

各ボイスチャンネル関連の機能で成功時にメッセージを送信する
4 participants