-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ボイスチャンネル関連の機能で成功時にメッセージを送信する #661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1sk9
added
improvement
Need more Hibikiness
I need more Hibikiness in the message
labels
Jan 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 72.30% 72.36% +0.06%
==========================================
Files 66 66
Lines 4632 4643 +11
Branches 438 437 -1
==========================================
+ Hits 3349 3360 +11
- Misses 848 849 +1
+ Partials 435 434 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MikuroXina
requested changes
Jan 5, 2023
https://wikiwiki.jp/kancolle/%E9%9F%BF/%E6%99%82%E5%A0%B1%E3%83%9C%E3%82%A4%E3%82%B9 |
MikuroXina
requested changes
Jan 19, 2023
MikuroXina
approved these changes
Jan 19, 2023
This was referenced Sep 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #660
Type of Change:
変更
Details of implementation (実施内容)
!gyokuon
,!kaere
実行に成功した際のメッセージを追加しました。響度が足りなかったらRCください、艦これは未履修なのでサジェストのほうが嬉しいです