Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: コウメ太夫構文ジェネレーターの追加 #584

Merged
merged 10 commits into from
Nov 25, 2022
Merged

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Nov 25, 2022

close #583

Type of Change:

以下の構文ジェネレーターを追加します。

!koume RSA鍵を登録した ed25519

RSA鍵を登録したと思ったら〜♪
ed25519 でした〜♪
チクショー!!
#毎日チクショー

@m1sk9 m1sk9 self-assigned this Nov 25, 2022
@m1sk9 m1sk9 enabled auto-merge (squash) November 25, 2022 13:08
src/service/command/meme/koume.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@MikuroXina MikuroXina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストを書きましょう

src/service/command/meme/koume.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #584 (a1786c5) into main (20d8f7d) will increase coverage by 0.05%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   73.78%   73.84%   +0.05%     
==========================================
  Files          62       63       +1     
  Lines        4513     4531      +18     
  Branches      399      401       +2     
==========================================
+ Hits         3330     3346      +16     
  Misses        785      785              
- Partials      398      400       +2     
Flag Coverage Δ
unittests 73.84% <89.47%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/command/meme/koume.ts 87.50% <87.50%> (ø)
src/service/command/meme/index.ts 95.65% <100.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Sponsor Contributor

@raiga0310 raiga0310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストのエラーメッセが半角空白なのは気になりましたがLGTMです

@m1sk9 m1sk9 merged commit e502323 into main Nov 25, 2022
@m1sk9 m1sk9 deleted the feat/koume branch November 25, 2022 13:35
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: コウメ太夫構文ジェネレーターの追加
4 participants