Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: アスタリスク6つのみのメッセージを無視 #575

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

KisaragiEffective
Copy link
Contributor

fix #574

Type of Change:

fix

Cause of the Problem (問題の原因)

アスタリスク3つの列が2つ以上メッセージに含まれているかどうかを判定していたため、アスタリスク6つのみのケースでもマッチしていた

Dealing with Problems (問題への対処)

条件をアスタリスク3つの列で囲われた部分が1文字以上あるかどうかに変更した

Details of implementation (実施内容)

同上

Additional Information (追加情報)

N/A

@codecov-commenter
Copy link

Codecov Report

Merging #575 (e632dab) into main (5458bbe) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files          62       62           
  Lines        4512     4513    +1     
  Branches      399      399           
=======================================
+ Hits         3329     3330    +1     
  Misses        785      785           
  Partials      398      398           
Flag Coverage Δ
unittests 73.78% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/bold-italic-cop.ts 82.85% <66.66%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KisaragiEffective KisaragiEffective merged commit c243d38 into main Nov 10, 2022
@KisaragiEffective KisaragiEffective deleted the KisaragiEffective-issue-574 branch November 10, 2022 17:45
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(bold-italic): メッセージの内容がアスタリスク6つの場合はBold-Italicではない
3 participants