Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stfu で削除個数を指定できるように #364

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Conversation

MikuroXina
Copy link
Collaborator

@MikuroXina MikuroXina commented Jul 31, 2022

Closes #347.

Type of Change:

機能の新規追加

Details of implementation (実施内容)

!stfu 25
のように削除個数を指定できるようになりました. 指定した回数分繰り返して実行したのと同じ扱いになります.

#347 で提案されていた探索範囲を指定できるようにする機能は, 大きくしすぎると予期しない古いメッセージの削除を招き, 小さくしすぎると全く削除できません. 少し使いづらいと判断して実装しませんでしたが, うまい活用方法やコマンド体系, 機能などがあればお申し付けください.

@MikuroXina MikuroXina self-assigned this Jul 31, 2022
@MikuroXina MikuroXina requested a review from m1sk9 July 31, 2022 13:22
@MikuroXina MikuroXina enabled auto-merge (squash) July 31, 2022 13:22
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022

Codecov Report

Merging #364 (e061add) into main (5ec6ef6) will increase coverage by 0.03%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   69.25%   69.29%   +0.03%     
==========================================
  Files          53       53              
  Lines        3487     3504      +17     
  Branches      331      335       +4     
==========================================
+ Hits         2415     2428      +13     
  Misses        741      741              
- Partials      331      335       +4     
Flag Coverage Δ
unittests 69.29% <82.60%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/command/stfu.ts 86.11% <82.60%> (-2.98%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@MikuroXina MikuroXina disabled auto-merge July 31, 2022 17:46
@MikuroXina MikuroXina enabled auto-merge (squash) July 31, 2022 17:59
@MikuroXina MikuroXina merged commit c528959 into main Jul 31, 2022
@MikuroXina MikuroXina deleted the feat/#347 branch July 31, 2022 18:30
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 粛清件数を引数にとりたい
3 participants