Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: version コマンドを追加 #255

Merged
merged 6 commits into from
Jun 14, 2022
Merged

feat: version コマンドを追加 #255

merged 6 commits into from
Jun 14, 2022

Conversation

MikuroXina
Copy link
Collaborator

Type of Change:

機能の新規追加

Cause of the Problem (問題の原因)

自動更新が成功したかどうかの確認などで, 現在起動してるボットのバージョンが何であるのか調べたいことがありました. 今まではこれをヘルプメッセージやコマンドの動作の変化などで確かめることがありましたが, 効率が悪いことでした.

Dealing with Problems (問題への対処)

MessageQuote のようにアクティビティに自身のバージョンを表示することも考えましたが, ひとまずはユーザ一覧を見に行かなくても確認できるコマンドとして実装することにしました.

Details of implementation (実施内容)

  • version コマンドを追加

Additional Information (追加情報)

この機能の単純さから, テストは不要と判断したため追加していません.

@MikuroXina MikuroXina requested a review from m1sk9 June 11, 2022 09:00
@MikuroXina MikuroXina self-assigned this Jun 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2022

Codecov Report

Merging #255 (38a6943) into main (01b02ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   68.24%   68.24%           
=======================================
  Files          43       43           
  Lines        2979     2979           
  Branches      260      260           
=======================================
  Hits         2033     2033           
  Misses        686      686           
  Partials      260      260           
Flag Coverage Δ
unittests 68.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b02ff...38a6943. Read the comment docs.

src/service/version.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
@MikuroXina MikuroXina merged commit 47fee10 into main Jun 14, 2022
@MikuroXina MikuroXina deleted the feat/version branch June 14, 2022 00:22
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants