-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avoid echo back when !stfu
was deleted
#251
Conversation
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 68.98% 68.95% -0.03%
==========================================
Files 49 49
Lines 3295 3305 +10
Branches 315 319 +4
==========================================
+ Hits 2273 2279 +6
Misses 707 707
- Partials 315 319 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stfu
と DeletionRepeater
の機能の間には関係性が無いので, 直接書くのは望ましくないです. 無視するパターンをコンストラクタで受け取るようにしてみてはどうでしょうか.
6184fc0
to
79cd255
Compare
d278b88
to
503c0d8
Compare
🎉 This PR is included in version 1.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
close #250
Issue: #250
Type of Change:
feat: メッセージの内容が正確に
!stfu
だった場合は当該メッセージを出さないようにしたCause of the Problem (問題の原因)
既存の実装の仕様
Dealing with Problems (問題への対処)
当該コミットにおいて変更を加えた
Details of implementation (実施内容)
当該コミット
Additional Information (追加情報)
N/A