Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid echo back when !stfu was deleted #251

Merged
merged 10 commits into from
Jul 23, 2022

Conversation

KisaragiEffective
Copy link
Contributor

@KisaragiEffective KisaragiEffective commented Jun 9, 2022

close #250

Issue: #250

Type of Change:

feat: メッセージの内容が正確に!stfuだった場合は当該メッセージを出さないようにした

Cause of the Problem (問題の原因)

既存の実装の仕様

Dealing with Problems (問題への対処)

当該コミットにおいて変更を加えた

Details of implementation (実施内容)

当該コミット

Additional Information (追加情報)

N/A

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #251 (0b7ae2b) into main (0828103) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   68.98%   68.95%   -0.03%     
==========================================
  Files          49       49              
  Lines        3295     3305      +10     
  Branches      315      319       +4     
==========================================
+ Hits         2273     2279       +6     
  Misses        707      707              
- Partials      315      319       +4     
Flag Coverage Δ
unittests 68.95% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/deletion-repeater.ts 89.39% <80.00%> (-5.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Collaborator

@MikuroXina MikuroXina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stfuDeletionRepeater の機能の間には関係性が無いので, 直接書くのは望ましくないです. 無視するパターンをコンストラクタで受け取るようにしてみてはどうでしょうか.

src/service/deletion-repeater.ts Outdated Show resolved Hide resolved
src/service/index.ts Outdated Show resolved Hide resolved
@MikuroXina MikuroXina force-pushed the feature/avoid-echo-back-on-stfu branch from 6184fc0 to 79cd255 Compare July 23, 2022 13:36
@MikuroXina MikuroXina force-pushed the feature/avoid-echo-back-on-stfu branch from d278b88 to 503c0d8 Compare July 23, 2022 13:41
@MikuroXina MikuroXina requested review from MikuroXina and m1sk9 and removed request for MikuroXina July 23, 2022 13:43
@MikuroXina MikuroXina self-assigned this Jul 23, 2022
@MikuroXina MikuroXina merged commit 7515a58 into main Jul 23, 2022
@MikuroXina MikuroXina deleted the feature/avoid-echo-back-on-stfu branch July 23, 2022 14:08
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: !stfuを消去したときは削除メッセージを復唱しない
4 participants