Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [critical] ファイル名の修正 #184

Merged
merged 4 commits into from
May 13, 2022
Merged

fix: [critical] ファイル名の修正 #184

merged 4 commits into from
May 13, 2022

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented May 13, 2022

Issue: No Issue

Type of Change:

  • rename: src/service/stfu.ts
  • rename: src/service/stfu.test.ts

Cause of the Problem (問題の原因)

Windowsでシステム上 ファイル名/ディレクトリ名 で使用できない記号 * が使用されているため、git clone がCLI/WebStorm上で正常に完了せず、Windowsが該当プロジェクトから締め出されてしまいました。

Details of implementation (実施内容)

* が使用されているファイル名をrenameしました。

Additional Information (追加情報)

  • 該当機能の開発者ではないため、どのようなファイル名にするべきかわかりませんでした。適したファイル名( * を使用しないもの) があったらこのPRでお願いします。 ( @raiga0310 )

@m1sk9 m1sk9 added bug labels May 13, 2022
@m1sk9 m1sk9 requested a review from raiga0310 May 13, 2022 09:53
@m1sk9 m1sk9 self-assigned this May 13, 2022
@m1sk9 m1sk9 changed the title fix: [Critical] ファイル名の修正 fix: [critical] ファイル名の修正 May 13, 2022
@raiga0310
Copy link
Sponsor Contributor

特にファイル名に思い入れはないのでその変更で問題ありませんがおそらく依存の関係などでテストが落ちていると思うのでIDEなどのrefactor 機能使って更新していただければと

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #184 (ae8dec9) into main (644c25a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files          35       35           
  Lines         749      749           
  Branches      122      122           
=======================================
  Hits          385      385           
  Misses        245      245           
  Partials      119      119           
Flag Coverage Δ
unittests 51.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/stfu.ts 80.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644c25a...ae8dec9. Read the comment docs.

@m1sk9 m1sk9 merged commit 56e07af into main May 13, 2022
@m1sk9 m1sk9 deleted the fix/file-name-stfu branch May 13, 2022 13:59
@MikuroXina MikuroXina linked an issue May 13, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.12.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants