Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 絵文字が作成されたら #無法地帯 にログを送信する機能の追加 #141

Merged
merged 17 commits into from
May 29, 2022

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Apr 30, 2022

Issue: #131

限界開発鯖に新しい絵文字が作成/削除されたら #無法地帯 にメッセージを送信する機能です。

  • Client#emojiCreate の受け取り部分
  • 絵文字作成ログの追加
  • 絵文字作成ログのテストケースの追加

@m1sk9 m1sk9 self-assigned this Apr 30, 2022
@m1sk9 m1sk9 linked an issue Apr 30, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #141 (3eca833) into main (78527bc) will decrease coverage by 0.36%.
The diff coverage is 38.09%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   51.83%   51.46%   -0.37%     
==========================================
  Files          40       42       +2     
  Lines         764      785      +21     
  Branches      120      122       +2     
==========================================
+ Hits          396      404       +8     
- Misses        250      261      +11     
- Partials      118      120       +2     
Flag Coverage Δ
unittests 51.46% <38.09%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/runner/emoji.ts 16.66% <16.66%> (ø)
src/service/emoji-log.ts 62.50% <62.50%> (ø)
src/runner/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78527bc...3eca833. Read the comment docs.

@m1sk9 m1sk9 marked this pull request as ready for review May 28, 2022 19:18
@m1sk9 m1sk9 enabled auto-merge (squash) May 28, 2022 19:18
@m1sk9 m1sk9 requested a review from MikuroXina May 28, 2022 19:29
src/adaptor/emoji-proxy.ts Outdated Show resolved Hide resolved
src/service/emoji-log.ts Outdated Show resolved Hide resolved
Meru and others added 2 commits May 29, 2022 10:59
Co-authored-by: Mikuroさいな <[email protected]>
Co-authored-by: Mikuroさいな <[email protected]>
@m1sk9 m1sk9 merged commit b4ac341 into main May 29, 2022
@m1sk9 m1sk9 deleted the feat/emoji-log branch May 29, 2022 02:13
@m1sk9 m1sk9 changed the title feat: 絵文字ログの追加 feat: 絵文字が作成されたら #無法地帯 にログを送信する機能の追加 May 29, 2022
@m1sk9 m1sk9 added the released label May 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: emoji作成ログ
3 participants