-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: メッセージが投稿後3秒以内に削除された場合に特殊メッセージを送信するように変更 #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikuroXina
requested changes
Jan 26, 2024
Deploying with
|
Latest commit: |
e3c9d55
|
Status: | ✅ Deploy successful! |
Preview URL: | https://9facc96f.oreorebot2.pages.dev |
Branch Preview URL: | https://feat-quick-deletion-message.oreorebot2.pages.dev |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
+ Coverage 56.62% 56.71% +0.08%
==========================================
Files 103 103
Lines 7020 7048 +28
Branches 515 517 +2
==========================================
+ Hits 3975 3997 +22
- Misses 2531 2535 +4
- Partials 514 516 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MikuroXina
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1247
Type of Change:
DeletionObservable
インターフェイスへの破壊的変更DeletionObservable
の変更に起因する型エラーの修正DeletionObservable
の変更に起因するテストケースのエラーを修正Details of implementation (実施内容)
実装したい機能を実現するために必要なフィールドを追加しました。このために発生したエラーを修正しました。
特殊メッセージを送信する条件を満たしているかを確認し、満たしている場合メッセージを切り替える処理を追加しました。また、特殊メッセージを送信する条件を満たしたときにメッセージが切り替わっていることを確認するテストを追加しました。
Additional Information (追加情報)