Skip to content

feat: メッセージが投稿後3秒以内に削除された場合に特殊メッセージを送信するように変更 #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 26, 2024

Conversation

aqyuki
Copy link
Member

@aqyuki aqyuki commented Jan 26, 2024

close #1247

Type of Change:

  • feat(interface)!: DeletionObservableインターフェイスへの破壊的変更
  • fix(type)!: DeletionObservableの変更に起因する型エラーの修正
  • fix(test)!: DeletionObservableの変更に起因するテストケースのエラーを修正
  • feat: メッセージを変化させるロジックを追加
  • test: 追加したロジックのテストケースを追加

Details of implementation (実施内容)

実装したい機能を実現するために必要なフィールドを追加しました。このために発生したエラーを修正しました。
特殊メッセージを送信する条件を満たしているかを確認し、満たしている場合メッセージを切り替える処理を追加しました。また、特殊メッセージを送信する条件を満たしたときにメッセージが切り替わっていることを確認するテストを追加しました。

Additional Information (追加情報)

@github-actions github-actions bot added the T-@oreorebot2/bot Type: OreOreBot2 Bot (packages/bot) label Jan 26, 2024
Copy link

cloudflare-workers-and-pages bot commented Jan 26, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e3c9d55
Status: ✅  Deploy successful!
Preview URL: https://9facc96f.oreorebot2.pages.dev
Branch Preview URL: https://feat-quick-deletion-message.oreorebot2.pages.dev

View logs

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (bd1129f) 56.62% compared to head (e3c9d55) 56.71%.

Files Patch % Lines
packages/bot/src/service/index.ts 0.00% 5 Missing ⚠️
packages/bot/src/service/deletion-repeater.ts 88.46% 0 Missing and 3 partials ⚠️
packages/bot/src/server/index.ts 0.00% 2 Missing ⚠️
...ot/src/adaptor/proxy/middleware/message-convert.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   56.62%   56.71%   +0.08%     
==========================================
  Files         103      103              
  Lines        7020     7048      +28     
  Branches      515      517       +2     
==========================================
+ Hits         3975     3997      +22     
- Misses       2531     2535       +4     
- Partials      514      516       +2     
Flag Coverage Δ
unittests 56.71% <67.64%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aqyuki aqyuki requested a review from MikuroXina January 26, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-@oreorebot2/bot Type: OreOreBot2 Bot (packages/bot)
Projects
None yet
2 participants