Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 国勢調査に人間の数の項目名を追加、改善 #104

Merged
merged 4 commits into from
Mar 29, 2022
Merged

feat: 国勢調査に人間の数の項目名を追加、改善 #104

merged 4 commits into from
Mar 29, 2022

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Mar 29, 2022

  • 国勢調査に 人間の数(BOTユーザではない一般ユーザー) を追加
  • 国勢調査の項目名を一部修正
  • 国勢調査のEmbedの値の位置を改善

@m1sk9 m1sk9 self-assigned this Mar 29, 2022
@m1sk9 m1sk9 changed the title Feat/people count feat: 国勢調査の項目を追加 Mar 29, 2022
@m1sk9 m1sk9 marked this pull request as ready for review March 29, 2022 14:37
@m1sk9 m1sk9 enabled auto-merge (squash) March 29, 2022 14:38
MikuroXina
MikuroXina requested changes Mar 29, 2022
View reviewed changes
src/service/kokusei-chousa.ts Outdated Show resolved Hide resolved
MikuroXina
MikuroXina requested changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@MikuroXina MikuroXina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR の名前がそのまま変更ログになるわけですが, 「国勢調査の項目を追加」ではなく何を追加したのかわかる名前にしておいてください.

@m1sk9 m1sk9 changed the title feat: 国勢調査の項目を追加 feat: 国勢調査に人間の数の項目名を追加、改善 Mar 29, 2022
@m1sk9 m1sk9 merged commit affe2e3 into main Mar 29, 2022
@m1sk9 m1sk9 deleted the feat/peopleCount branch March 29, 2022 15:14
@m1sk9 m1sk9 added the released label May 31, 2022
@github-actions github-actions bot mentioned this pull request Dec 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikuroXina MikuroXina MikuroXina approved these changes

Assignees

@m1sk9 m1sk9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1sk9 @MikuroXina