Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar chart plot options should allow for range of colors like JavaScript API #90

Open
Obi-TP opened this issue Dec 31, 2020 · 1 comment
Labels
enhancement New feature or request will accept PR

Comments

@Obi-TP
Copy link

Obi-TP commented Dec 31, 2020

Is your feature request related to a problem? Please describe.
com.github.appreciated.apexcharts.config.plotoptions.bar.Colors.setRanges(Ranges) is not consistent with JavaScript API. It should accept a var array (or collection of colors).

Describe the solution you'd like
Change the API to accept an array of colors.

Additional context
I am happy to contribute a solution if you will accept a Pull Request. See excerpt below.

package com.github.appreciated.apexcharts.config.plotoptions.bar;

import java.util.List;

public class Colors {
    private Ranges[] ranges;
    private List<String> backgroundBarColors;
    private Double backgroundBarOpacity;

    public Colors() {
    }

    public Ranges[] getRanges() {
        return ranges;
    }

    public List<String> getBackgroundBarColors() {
        return backgroundBarColors;
    }

    public Double getBackgroundBarOpacity() {
        return backgroundBarOpacity;
    }

    public void setRanges(Ranges ...ranges) {
        this.ranges = ranges;
    }

    public void setBackgroundBarColors(List<String> backgroundBarColors) {
        this.backgroundBarColors = backgroundBarColors;
    }

    public void setBackgroundBarOpacity(Double backgroundBarOpacity) {
        this.backgroundBarOpacity = backgroundBarOpacity;
    }

}
@Obi-TP Obi-TP added the enhancement New feature or request label Dec 31, 2020
@Obi-TP Obi-TP changed the title Bar chart plot options should allow for range of colors like javascript API Bar chart plot options should allow for range of colors like JavaScript API Dec 31, 2020
@appreciated
Copy link
Owner

@Obi-TP I would be glad if you could provide a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request will accept PR
Projects
None yet
Development

No branches or pull requests

2 participants