Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given logger not respected by S3 connection #32

Open
bradseefeld opened this issue Jun 3, 2011 · 1 comment
Open

Given logger not respected by S3 connection #32

bradseefeld opened this issue Jun 3, 2011 · 1 comment

Comments

@bradseefeld
Copy link

If I explicitly specify a Logger when creating a simple_record connection, the logger is not passed into the S3 connection.

For example:

SimpleRecord.establish_connection(aws_id, aws_secret, :connection_mode => :per_thread, :s3_bucket => :new, :logger => logger)

I believe the fix is just adding the simple_record logger to the s3_opts hash: https://github.com/appoxy/simple_record/blob/master/lib/simple_record.rb line 137

Additionally, it might be a good idea to pass other connection configuration settings. I have not dived into simple_record/aws enough to make a recommendation regarding if anything should be passed along but I am sure you would know ;)

@gurugeek
Copy link

anyone can add S3 to logger? it would be good for debugging. Anyone willing to fix this for a fee ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants