ModuleInterface: teach -compile-module-from-interface to emit forwarding module #32985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing module -compile-module-from-interface action now takes arguments of -candidate-module-file. If one of the candidate module files is up-to-date, the action emits a forwarding module pointing to the candidate module instead of building a binary module.
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci Please smoke test OS X platform |
finagolfin
reviewed
Jul 20, 2020
| // RUN: %empty-directory(%t) | ||
| // RUN: %empty-directory(%t/Foo.swiftmodule) | ||
| // RUN: %empty-directory(%t/ResourceDir/%target-sdk-name/prebuilt-modules/Foo.swiftmodule) | ||
| // RUN: echo "public func foo() {}" > %t/Foo.swift |
Member
There was a problem hiding this comment.
This test has broken the macOS CI:
FAIL: Swift(macosx-x86_64) :: ModuleInterface/emit-forward-modules.swift (699 of 13520)
******************** TEST 'Swift(macosx-x86_64) :: ModuleInterface/emit-forward-modules.swift' FAILED ********************
--snip commands--
Command Output (stdout):
--
swiftmodule '/Volumes/swift-ci/jenkins/workspace/swift-PR-osx/branch-master/buildbot_incremental/swift-macosx-x86_64/test-macosx-x86_64/ModuleInterface/Output/emit-forward-modules.swift.tmp/Foo.swiftmodule/x86_64-apple-macos.swiftmodule' is not a forwarding module!
--
Command Output (stderr):
--
<unknown>:0: warning: module interfaces are only supported with Swift language version 5 or later (currently using -swift-version 4)
<unknown>:0: warning: module interfaces are only supported with -enable-library-evolution
Two completely unrelated pulls fail the CI because of this one test.
Contributor
There was a problem hiding this comment.
I attempted to contact some people that can revert this if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-compile-module-from-interface action now takes arguments of -candidate-module-file.
If one of the candidate module files is up-to-date, the action emits a forwarding
module pointing to the candidate module instead of building a binary module.