SE-0072: Fully eliminate implicit bridging conversions from Swift #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Swift Evolution proposal SE-0072, these changes prevent the compiler from introducing implicit bridging conversions during type checking.
|
@swift-ci Please test |
| self.z = SCNFloat(z) | ||
| self.x = SCNFloat(x as NSNumber) | ||
| self.y = SCNFloat(y as NSNumber) | ||
| self.z = SCNFloat(z as NSNumber) |
There was a problem hiding this comment.
Oh, I don't think that was intended.
#if os(OSX)
public typealias SCNFloat = CGFloat
#elseif os(iOS) || os(tvOS)
public typealias SCNFloat = Float
#endifGiven this definition, this was intended as a plain conversion, not a bridge.
There was a problem hiding this comment.
Agreed - debugging in, though, we've definitely been introducing this conversion implicitly. I've filed SR-1432 to track my investigation of what's been going on.
|
I'm amazed how few of these we had in the testsuite. |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please ASAN test |
|
@swift-ci smoke test OS X platform |
|
@swift-ci smoke test OS X platform |
|
@swift-ci Please test |
|
The failing smoke tests should be fixed by @lattner's recent commits, so this is now safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0072: Fully eliminate implicit bridging conversions from Swift
Per Swift Evolution proposal SE-0072, these changes prevent the compiler from introducing implicit bridging conversions during type checking.