Added support for the "Split" op and added a VJP for the casting initializer. #24120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rxwei merged 5 commits into swiftlang:tensorflow from eaplatanios:split-op

Apr 18, 2019

eaplatanios commented Apr 18, 2019

No description provided.

eaplatanios added 3 commits

April 18, 2019 10:38


          Added support for the split op.

cf7cae0


          Minor edit.

09ad1e9


          Added VJP for the casting initializer.

ba07887

eaplatanios changed the title ~~Added support for the "Split" op.~~ Added support for the "Split" op and added a VJP for the casting initializer.

Contributor

rxwei commented Apr 18, 2019

Could we make sure Split is tested or has a use case?

rxwei reviewed

View reviewed changes

Contributor

rxwei left a comment

The cast part LGTM.

stdlib/public/TensorFlow/Tensor.swift Outdated Show resolved Hide resolved

stdlib/public/TensorFlow/Tensor.swift Outdated Show resolved Hide resolved

rxwei and others added 2 commits

April 18, 2019 14:15


          Update stdlib/public/TensorFlow/Tensor.swift

ba93596

Co-Authored-By: eaplatanios <[email protected]>


          Update stdlib/public/TensorFlow/Tensor.swift

2f499d8

Co-Authored-By: eaplatanios <[email protected]>

Author

eaplatanios commented Apr 18, 2019

Could we make sure Split is tested or has a use case?

It's kind of dual to SplitV in that, if you want to split in equal parts (e.g., when "unstacking" a tensor along the batch dimension), you'd need to compute the size of each split and copy over an array with the sizes, if using SplitV. Split lets you do that by just providing the number of splits you want. I'm planning to add a split function to Tensor in the open PR in swift-apis soon. I have implemented them but need to add VJPs and then will push changes there.

Contributor

rxwei commented Apr 18, 2019

OK. I just want to make sure it's at least tested on your machine so that you won't need to come back and change it if it doesn't work.

Author

eaplatanios commented Apr 18, 2019

Yes that makes sense. Give me a couple hours maybe and I'll post here once I've tested it. :)

Author

eaplatanios commented Apr 18, 2019

@rxwei Just tested locally and it works fine. :)

Contributor

rxwei commented Apr 18, 2019

@swift-ci please test tensorflow

4 similar comments

Contributor

rxwei commented Apr 18, 2019

@swift-ci please test tensorflow

Contributor

rxwei commented Apr 18, 2019

@swift-ci please test tensorflow

Contributor

rxwei commented Apr 18, 2019

@swift-ci please test tensorflow

Contributor

rxwei commented Apr 18, 2019

@swift-ci please test tensorflow

Contributor

rxwei commented Apr 18, 2019

@swift-ci please test tensorflow Linux

rxwei added the tensorflow label

rxwei merged commit 162caae into swiftlang:tensorflow

rxwei pushed a commit to rxwei/swift that referenced this pull request


          Added support for the "Split" op and added a VJP for the casting init…

2ef84e0

…ializer. (swiftlang#24120)

* Added support for the split op.

* Minor edit.

* Added VJP for the casting initializer.

* Update stdlib/public/TensorFlow/Tensor.swift

Co-Authored-By: eaplatanios <[email protected]>

* Update stdlib/public/TensorFlow/Tensor.swift

Co-Authored-By: eaplatanios <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels