Use the new warning control instead of unsafeFlags
#1882
Conversation
## Motivation In my recent work to build `protoc` from source I mistakenly disabled warnings by using unsafe flags. Unsafe flags make packages essentially unusable. ## Modifications Disable the warnings by using the new warning control settings introduced in 6.2 instead. ## Result Fixes apple#1881
FranzBusch
force-pushed
the
fb-disable-warnings
branch
from
a5b6f25 to
cedb136
Compare
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.10 | |||
| // swift-tools-version:6.2 | |||
There was a problem hiding this comment.
This will cause everything to compile in Swift 6 language mode as well, right? That's probably fine (if we've fixed all the relevant issues), but should we add in swiftLanguageModes: [.v5] for now so that we don't change the language mode as part of an otherwise unrelated change, and then we can go back and audit it for Swift 6 support later?
There was a problem hiding this comment.
I was aware and wanted to see what the CI says. It looks like we are compiling cleanly in Swift 6 mode. I will change it back to Swift 5 mode for now.
There was a problem hiding this comment.
Just when I wrote this comment I saw that we are actually setting the language mode already in all of our manifests.
There was a problem hiding this comment.
Well that's what I get for not expanding the diff far enough.
3 participants
Motivation
In my recent work to build
protocfrom source I mistakenly disabled warnings by using unsafe flags. Unsafe flags make packages essentially unusable.Modifications
Disable the warnings by using the new warning control settings introduced in 6.2 instead.
Result
Fixes #1881