Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.10] Update Options.swift for '-disable-sandbox' #1493

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Nov 29, 2023

Cherry-pick #1490 into release/5.10

  • Explanation: Update Options.swift for newly introduced -disable-sandbox and forward the option to swift-frontend.
  • Scope: Frontend options
  • Risk: Low. The change is localized, and straightforward
  • Testing: Current test suite cases
  • Issues: rdar://118419424
  • Reviewer: Artem Chikin (@artemcm)

@rintaro
Copy link
Member Author

rintaro commented Nov 29, 2023

@swift-ci Please test

@rintaro rintaro requested a review from bnbarham November 29, 2023 00:24
@rintaro rintaro merged commit fce44ae into swiftlang:release/5.10 Nov 30, 2023
keith pushed a commit to bazelbuild/rules_swift that referenced this pull request May 22, 2024
…xing (#1206)

This should solve #1202
 and #1204

> There were issues with Swift compiler plugins (incl. macros) and
nested sandboxes on macOS with Swift 5.9 that have been fixed with 5.10:
> swift: [swiftlang/swift#70079](swiftlang/swift#70079)
> swift-driver:
[swiftlang/swift-driver#1493](swiftlang/swift-driver#1493)
> swift-package-manager:
[swiftlang/swift-package-manager#7167](swiftlang/swift-package-manager#7167)


I am not sure whether this flag is required on Linux too.

---------

Signed-off-by: Adin Cebic <[email protected]>
Co-authored-by: Brentley Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants