-
Notifications
You must be signed in to change notification settings - Fork 78
Swift 5.3 was released, use it for CI #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
motivation: Swift 5.3 was released, use if for CI changes: update docker setup to use the release version of 5.3
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
|
@ktoso tests failed 3 time. flaky, or is this a genuine 5.3 issue? |
|
I believe the failure is expected: #746 (comment) |
|
Yes that's the release compilation failure. FYI @tomerd We decided to merge and keep moving forward and reported the radar: rdar://68467435 The fix has been merged to the We may have to remain on nightly for now until 5.3.1 is out |
|
// The nightly Swift 5.3 is ~14 days behind and the fix was merged 7 days ago, so Swift 5.3 nightly still is failing compilation |
|
So I decided to skip the known-to-fail release compilation requiring integration test #773 since it was adding much noise in all PRs... We could re-enable it as soon as the nightly docker image ships the fixed build, but in order to move to 5.3-RELEASE we'll need 5.3.1 (same goes for prod users) |
|
waiting for 5.3.1 seems right to me |
|
Sounds good, thanks 👍 |
|
@swift-server-bot test this please |
|
replaced by #793 |
motivation: Swift 5.3 was released, use if for CI
changes: update docker setup to use the release version of 5.3