=regex workaround for crashes on String.starts(with:) caused by rdar://98691039

Author: ktoso

Sources/DistributedActorsTestKit/Cluster/ClusteredActorSystemsXCTestCase.swift

@@ -96,18 +96,18 @@ open class ClusteredActorSystemsXCTestCase: XCTestCase {
             self.actorStatsBefore = try InspectKit.actorStats()
         }
 
-        self.stuckTestDumpLogsTask = Task.detached {
-            try await Task.sleep(until: .now + self.dumpLogsAfter, clock: .continuous)
-            guard !Task.isCancelled else {
-                return
-            }
-
-            print("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!")
-            print("!!!!!!!!!!               TEST SEEMS STUCK - DUMPING LOGS                   !!!!!!!!!!")
-            print("!!!!!!!!!!               PID: \(ProcessInfo.processInfo.processIdentifier)                              !!!!!!!!!!")
-            print("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!")
-            self.printAllCapturedLogs()
-        }
+//        self.stuckTestDumpLogsTask = Task.detached {
+//            try await Task.sleep(until: .now + self.dumpLogsAfter, clock: .continuous)
+//            guard !Task.isCancelled else {
+//                return
+//            }
+//
+//            print("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!")
+//            print("!!!!!!!!!!               TEST SEEMS STUCK - DUMPING LOGS                   !!!!!!!!!!")
+//            print("!!!!!!!!!!               PID: \(ProcessInfo.processInfo.processIdentifier)                              !!!!!!!!!!")
+//            print("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!")
+//            self.printAllCapturedLogs()
+//        }
         try await super.setUp()
     }
 

Sources/DistributedActorsTestKit/InspectKit.swift

@@ -13,10 +13,8 @@
 //===----------------------------------------------------------------------===//
 
 import Foundation
-#if swift(>=5.8.0)
 // FIXME(regex): rdar://98705227 can't use regex on 5.7 on Linux because of a bug that crashes String.starts(with:) at runtime then
 import RegexBuilder
-#endif
 import XCTest
 
 internal struct InspectKit {
@@ -146,7 +144,6 @@ internal struct InspectKit {
 
     /// Actor names to their counts
     static func actorStats() throws -> ActorStats {
-        #if swift(>=5.8.0)
         // FIXME(regex): rdar://98705227 can't use regex on 5.7 on Linux because of a bug that crashes String.starts(with:) at runtime then
         let (out, err, _) = Self.runCommand(cmd: "\(self.baseDir)/scripts/dump_actors.sh")
 
@@ -175,9 +172,6 @@ internal struct InspectKit {
         }
 
         return ActorStats(stats: stats)
-        #else
-        return .init()
-        #endif
     }
 }
 

Sources/DistributedActorsTestKit/LogCapture.swift

@@ -204,7 +204,13 @@ struct LogCaptureLogHandler: LogHandler {
     public func log(level: Logger.Level, message: Logger.Message, metadata: Logger.Metadata?, file: String, function: String, line: UInt) {
         let actorPath = self.metadata["actor/path"].map { "\($0)" } ?? ""
 
-        guard self.capture.settings.filterActorPaths.contains(where: { path in actorPath.starts(with: path) }) else {
+        guard self.capture.settings.filterActorPaths.contains(where: { path in
+            if (path == "") { // TODO(swift): rdar://98691039 String.starts(with:) has a bug when given an empty string, so we have to avoid it
+                return true
+            }
+
+            return actorPath.starts(with: path)
+        }) else {
             return // ignore this actor's logs, it was filtered out
         }
         guard !self.capture.settings.excludeActorPaths.contains(actorPath) else {

Sources/MultiNodeTestKitRunner/boot+MultiNodeTestKitRunner+Exec.swift

@@ -135,5 +135,4 @@ extension MultiNodeTestKitRunnerBoot {
         }
         return .init(uniqueKeysWithValues: nodeList)
     }
-
 }

Sources/MultiNodeTestKitRunner/boot+MultiNodeTestKitRunner+Test.swift

@@ -16,7 +16,7 @@ import ArgumentParser
 import DistributedActors
 import struct Foundation.Date
 import class Foundation.FileHandle
-import class Foundation.Process
+@preconcurrency import class Foundation.Process
 import class Foundation.ProcessInfo
 import struct Foundation.URL
 import MultiNodeTestKit
@@ -237,7 +237,6 @@ extension MultiNodeTestKitRunnerBoot {
             process.terminate()
         }
     }
-
 }
 
 struct NodeInterpretedRunResult {

Tests/DistributedActorsTests/ClusterSystem+ActorTransportTests.swift renamed to Tests/DistributedActorsTests/BasicClusterSystemLifecycleTests.swift

@@ -16,8 +16,7 @@
 import DistributedActorsTestKit
 import XCTest
 
-// FIXME: rename
-final class ActorSystemTransportTests: SingleClusterSystemXCTestCase, @unchecked Sendable {
+final class BasicClusterSystemLifecycleTests: SingleClusterSystemXCTestCase, @unchecked Sendable {
     func test_system_shouldAssignIdentityAndReadyActor() async throws {
         try runAsyncAndBlock {
             let first = await setUpNode("first")