Add test for allowed but unregistered error type

Author: yim-lee

Sources/DistributedActors/ClusterSystem.swift

@@ -1502,10 +1502,10 @@ public struct ClusterInvocationResultHandler: DistributedTargetInvocationResultH
                 case .all: // compiler gets confused if this is grouped together with above
                     reply = .init(callID: callID, error: codableError)
                 default:
-                    reply = .init(callID: callID, error: GenericRemoteCallError(message: "Remote call error of [\(errorType)] type occurred"))
+                    reply = .init(callID: callID, error: GenericRemoteCallError(errorType: errorType))
                 }
             } else {
-                reply = .init(callID: callID, error: GenericRemoteCallError(message: "Remote call error of [\(errorType)] type occurred"))
+                reply = .init(callID: callID, error: GenericRemoteCallError(errorType: errorType))
             }
             try await channel.writeAndFlush(TransportEnvelope(envelope: Payload(payload: .message(reply)), recipient: recipient))
         }
@@ -1595,6 +1595,14 @@ struct RemoteCallReply<Value: Codable>: AnyRemoteCallReply {
 
 public struct GenericRemoteCallError: Error, Codable {
     public let message: String
+
+    init(message: String) {
+        self.message = message
+    }
+
+    init(errorType: Any.Type) {
+        self.message = "Remote call error of [\(errorType)] type occurred"
+    }
 }
 
 public enum ClusterSystemError: DistributedActorSystemError {

Tests/DistributedActorsTests/RemoteCallTests.swift

@@ -231,9 +231,10 @@ final class RemoteCallTests: ClusteredActorSystemsXCTestCase {
         let error = try await shouldThrow {
             _ = try await remoteGreeterRef.helloThrow(codable: true)
         }
-        guard error is GenericRemoteCallError else {
+        guard let remoteCallError = error as? GenericRemoteCallError else {
             throw TestError("Expected GenericRemoteCallError, got \(error)")
         }
+        remoteCallError.message.shouldStartWith(prefix: "Remote call error of [GreeterCodableError] type occurred")
     }
 
     func test_remoteCall_customCodableErrorAllowList_errorInList() async throws {
@@ -260,6 +261,28 @@ final class RemoteCallTests: ClusteredActorSystemsXCTestCase {
         }
     }
 
+    func test_remoteCall_customCodableErrorAllowList_errorInListButNotRegistered() async throws {
+        let local = await setUpNode("local") { settings in
+            settings.remoteCall.codableErrorAllowance = .custom(allowedTypes: [GreeterCodableError.self, AnotherGreeterCodableError.self])
+        }
+        let remote = await setUpNode("remote") { settings in
+            settings.remoteCall.codableErrorAllowance = .custom(allowedTypes: [GreeterCodableError.self, AnotherGreeterCodableError.self])
+        }
+        local.cluster.join(node: remote.cluster.uniqueNode)
+
+        let greeter = Greeter(actorSystem: local)
+        let remoteGreeterRef = try Greeter.resolve(id: greeter.id, using: remote)
+
+        let error = try await shouldThrow {
+            try await RemoteCall.with(timeout: .milliseconds(200)) {
+                _ = try await remoteGreeterRef.helloThrow(codable: true)
+            }
+        }
+        guard case RemoteCallError.timedOut = error else {
+            throw TestError("Expected RemoteCallError.timedOut, got \(error)")
+        }
+    }
+
     func test_remoteCall_customCodableErrorAllowList_errorNotInList() async throws {
         let local = await setUpNode("local") { settings in
             settings.remoteCall.codableErrorAllowance = .custom(allowedTypes: [AnotherGreeterCodableError.self])
@@ -279,9 +302,10 @@ final class RemoteCallTests: ClusteredActorSystemsXCTestCase {
         let error = try await shouldThrow {
             _ = try await remoteGreeterRef.helloThrow(codable: true)
         }
-        guard error is GenericRemoteCallError else {
+        guard let remoteCallError = error as? GenericRemoteCallError else {
             throw TestError("Expected GenericRemoteCallError, got \(error)")
         }
+        remoteCallError.message.shouldStartWith(prefix: "Remote call error of [GreeterCodableError] type occurred")
     }
 }