Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestPublisher should notice invalid re-use after termination #1733

Open
chemicL opened this issue Aug 16, 2021 · 0 comments
Open

TestPublisher should notice invalid re-use after termination #1733

chemicL opened this issue Aug 16, 2021 · 0 comments

Comments

@chemicL
Copy link
Contributor

chemicL commented Aug 16, 2021

As noticed by @ idelpivnitskiy: in RoundRobinLoadBalancerTest the serviceDiscoveryPublisher is completed but later onNext is invoked. It violates the spec. TestPublisher should validate such misuse and the tests should create a new publisher.
@chemicL chemicL mentioned this issue Aug 16, 2021
Merged
@idelpivnitskiy idelpivnitskiy changed the title TestPublisher should notice invalid re-use after onComplete is called. TestPublisher should notice invalid re-use after termination Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chemicL