From db9a0264d084f3c965d7ebea30ff3c98f8a5cced Mon Sep 17 00:00:00 2001 From: Bryce Anderson Date: Wed, 7 Feb 2024 12:00:50 -0700 Subject: [PATCH] http-netty: Disable some GraceulConnectionClosureHandling tests (#2827) Motivation: The tests are super flaky making it almost impossible to get a clean CI run. The problem was in netty and has been fixed but we're waiting on a release. Modifications: - Disable the flaky tests and add some notes to the netty dependency --- gradle.properties | 1 + .../http/netty/GracefulConnectionClosureHandlingTest.java | 3 +++ 2 files changed, 4 insertions(+) diff --git a/gradle.properties b/gradle.properties index 7b026ff3c3..cb9f4a45a1 100644 --- a/gradle.properties +++ b/gradle.properties @@ -30,6 +30,7 @@ issueManagementUrl=https://github.com/apple/servicetalk/issues ciManagementUrl=https://github.com/apple/servicetalk/actions # dependency versions +# on next netty upgrade re-enable the GracefulConnectionCluser tests. See issue #2117 nettyVersion=4.1.106.Final nettyIoUringVersion=0.0.24.Final diff --git a/servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/GracefulConnectionClosureHandlingTest.java b/servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/GracefulConnectionClosureHandlingTest.java index 5531acb742..c88c7ad72c 100644 --- a/servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/GracefulConnectionClosureHandlingTest.java +++ b/servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/GracefulConnectionClosureHandlingTest.java @@ -50,6 +50,7 @@ import io.servicetalk.transport.netty.internal.ExecutionContextExtension; import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.extension.RegisterExtension; import org.junit.jupiter.api.function.Executable; import org.junit.jupiter.params.ParameterizedTest; @@ -425,6 +426,7 @@ void closeAfterFullRequestSentNoResponseReceived(HttpProtocol protocol, assertNextRequestFails(); } + @Disabled("Issue 2117") @ParameterizedTest(name = "{index}: protocol={0} secure={1} initiateClosureFromClient={2} useUds={3} viaProxy={4}") @MethodSource("data") void closeAfterRequestMetaDataSentResponseMetaDataReceived(HttpProtocol protocol, @@ -517,6 +519,7 @@ void closeAfterRequestMetaDataSentFullResponseReceived(HttpProtocol protocol, assertNextRequestFails(); } + @Disabled("Issue 2117") @ParameterizedTest(name = "{index}: protocol={0} secure={1} initiateClosureFromClient={2} useUds={3} viaProxy={4}") @MethodSource("data") void closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceived(HttpProtocol protocol,