From d8ec4073a8a846f3ba0d3b64a0fee3f7d4f66ea3 Mon Sep 17 00:00:00 2001 From: chxhyxn Date: Sun, 6 Jul 2025 03:07:05 +0900 Subject: [PATCH 1/2] =?UTF-8?q?fix:=20maxpPositionEmbeddings=20=E2=86=92?= =?UTF-8?q?=20maxPositionEmbeddings?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Rename 'maxpPositionEmbeddings' to 'maxPositionEmbeddings' --- app/FastVLM/FastVLM.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/FastVLM/FastVLM.swift b/app/FastVLM/FastVLM.swift index 731b0ef..3c047b5 100644 --- a/app/FastVLM/FastVLM.swift +++ b/app/FastVLM/FastVLM.swift @@ -585,7 +585,7 @@ public struct FastVLMConfiguration: Codable, Sendable { public let vocabularySize: Int public let kvHeads: Int private let _maxPositionEmbeddings: Int? - public var maxpPositionEmbeddings: Int { _maxPositionEmbeddings ?? 32768 } + public var maxPositionEmbeddings: Int { _maxPositionEmbeddings ?? 32768 } private let _ropeTheta: Float? public var ropeTheta: Float { _ropeTheta ?? 1_000_000 } private let _ropeTraditional: Bool? From 691e8da86013de7c31cf2afc34d0f24689c9c918 Mon Sep 17 00:00:00 2001 From: chxhyxn Date: Sun, 6 Jul 2025 03:08:46 +0900 Subject: [PATCH 2/2] =?UTF-8?q?fix:=20detatch=20=E2=86=92=20detach?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Rename 'detatch' to 'detach' --- app/FastVLM App/ContentView.swift | 2 +- app/Video/CameraController.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/FastVLM App/ContentView.swift b/app/FastVLM App/ContentView.swift index 7bcf693..5cbdd2d 100644 --- a/app/FastVLM App/ContentView.swift +++ b/app/FastVLM App/ContentView.swift @@ -410,7 +410,7 @@ struct ContentView: View { // detach from the camera controller and feed to the video view await MainActor.run { self.framesToDisplay = nil - self.camera.detatch() + self.camera.detach() } framesToDisplayContinuation.finish() diff --git a/app/Video/CameraController.swift b/app/Video/CameraController.swift index 9428361..b2a94e9 100644 --- a/app/Video/CameraController.swift +++ b/app/Video/CameraController.swift @@ -43,7 +43,7 @@ public class CameraController: NSObject { } } - public func detatch() { + public func detach() { sessionQueue.async { self.framesContinuation = nil }