Skip to content

Conversation

@tachoknight
Copy link

std::abort had been implicitly included, which Clang 10 does not like.

@compnerd
Copy link
Member

compnerd commented Jun 9, 2020

CC: @hyp @JDevlieghere

This file has been removed upstream, so it doesn't make sense to apply this change upstream. We should just apply it to the stable branch and let it flow to the master branch. There will be no need for this change in master-next as by that time the file is gone. This repairs the build on RH based (sorry @tachoknight, whats the correct term here? RHEL based? Fedora based? RH based?) distributions.

@compnerd
Copy link
Member

compnerd commented Jun 9, 2020

@swift-ci please test

@tachoknight
Copy link
Author

whats the correct term here? RHEL based? Fedora based? RH based?) distributions
Fedora-based; RHEL and CentOS are forked from Fedora. :)

@shahmishal
Copy link
Member

Thanks @tachoknight!

@shahmishal shahmishal merged commit 6419f1c into swiftlang:apple/stable/20200108 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants