io.appium.settings: recording: Do not modify recording file name in case of invalid file name

* simply return error and exit, because providing alternative/default name causes confusion on users while pulling file

Signed-off-by: sirmordred <[email protected]>

Author: sirmordred

app/src/main/java/io/appium/settings/RecorderConstant.java

@@ -24,7 +24,6 @@ public class RecorderConstant {
     public static final String ACTION_RECORDING_RESULT_CODE = "result_code";
     public static final String ACTION_RECORDING_FILENAME = "recording_filename";
     public static final String ACTION_RECORDING_ROTATION = "recording_rotation";
-    public static final String DEFAULT_RECORDING_FILENAME = "AppiumScreenRecord";
     public static final float BITRATE_MULTIPLIER = 0.25f;
     public static final int AUDIO_CODEC_SAMPLE_RATE_HZ = 44100;
     public static final int AUDIO_CODEC_CHANNEL_COUNT = 1;

app/src/main/java/io/appium/settings/Settings.java

@@ -33,11 +33,8 @@
 import android.view.WindowManager;
 
 import java.io.File;
-import java.text.SimpleDateFormat;
 import java.util.Arrays;
-import java.util.Date;
 import java.util.List;
-import java.util.Locale;
 
 import androidx.core.app.ActivityCompat;
 import io.appium.settings.receivers.AnimationSettingReceiver;
@@ -132,12 +129,9 @@ private void handleRecording(Intent intent) {
         String recordingFilename = intent.getStringExtra(ACTION_RECORDING_FILENAME);
 
         if (isValidFileName(recordingFilename)) {
-            String timeStamp = new SimpleDateFormat(
-                    "yyyy-MM-dd_HH-mm-ss", Locale.US).format(new Date());
-            recordingFilename = RecorderConstant.DEFAULT_RECORDING_FILENAME +
-                    "_" + timeStamp + ".mp4";
-            Log.w(TAG, "handleRecording: Invalid filename passed by user," +
-                    " using default one: " + recordingFilename);
+            Log.e(TAG, "handleRecording: Invalid filename passed by user");
+            finishActivity();
+            return;
         }
 
         /*