Skip to content

Conversation

@Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Nov 5, 2022

In case we would like to rename the repo to match the other clients in the appium project, this is a good place to start.
As discussed with @akinsolb on slack

Change list

Please provide briefly described change list which are you going to propose.

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

In case we would like to rename the repo to match the other clients in the appium project, this is a good place to start.
@Dor-bl Dor-bl requested a review from laolubenson November 5, 2022 14:31
@Dor-bl Dor-bl changed the title docs: rename repo in README.MD docs: rename repo to dotnet-client in README.MD Nov 5, 2022
@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 5, 2022

@jlipps any issue from your side with the idea of changing the repo name?

@jlipps
Copy link
Member

jlipps commented Nov 7, 2022

Seems fine if it's a significant improvement in your opinion. I'm not sure what all consequences would be but I do know that github creates redirects for urls in the old repo. Can you double check the appium 2 docs and update any links to it?

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 9, 2022

@akinsolb should we move forward with the Rename? I can open a PR on Appium for the links change

@laolubenson
Copy link
Collaborator

@akinsolb should we move forward with the Rename? I can open a PR on Appium for the links change

Yeah I was going to suggest creating a new ticket to manage all outstanding tasks as opposed to this PR. I'm happy to progress with renaming and merging this PR.

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 11, 2022

@akinsolb should we rename the Product value in the .csproj as well?
Appium-Dotnet-Driver

@Dor-bl Dor-bl changed the title docs: rename repo to dotnet-client in README.MD refactor: Rename repository to dotnet-client Nov 11, 2022
@laolubenson
Copy link
Collaborator

@akinsolb should we rename the Product value in the .csproj as well?

<Product>Appium-Dotnet-Driver</Product>

Yep

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 11, 2022

@akinsolb should we rename the Product value in the .csproj as well?

<Product>Appium-Dotnet-Driver</Product>

Yep

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants