feat: Jump selenium from 4.0.0 to 4.4.0 (#517)

* Target .NET Framework 4.8

* test:Fix ClipboardTests

* Update Selenium from 4.0.0 to 4.4.0.
Removal of Obsolete AddAdditionalCapability
Implement GetDomProperty

* Removal of GetDomProperty

Author: Dor-bl

src/Appium.Net/Appium.Net.csproj

@@ -46,8 +46,8 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Selenium.Support" Version="4.0.0" />
-    <PackageReference Include="Selenium.WebDriver" Version="4.0.0" />
+    <PackageReference Include="Selenium.Support" Version="4.4.0" />
+    <PackageReference Include="Selenium.WebDriver" Version="4.4.0" />
   </ItemGroup>
 
   <ItemGroup>

src/Appium.Net/Appium/AppiumElement.cs

@@ -155,9 +155,10 @@ public override string GetCssValue(string propertyName) => CacheValue(
                 () => base.GetCssValue(propertyName)
             )?.ToString();
 
-        public override string GetProperty(string propertyName) => CacheValue(
+        //TODO: Add Integrations tests 
+        public string GetProperty(string propertyName) => CacheValue(
                 "property/" + propertyName,
-                () => base.GetProperty(propertyName)
+                () => base.GetDomProperty(propertyName)
             )?.ToString();
 
         protected virtual object CacheValue(string key, Func<object> getter)

src/Appium.Net/Appium/AppiumOptions.cs

@@ -82,17 +82,6 @@ public void AddAdditionalAppiumOption(string optionName, object optionValue)
             this.additionalAppiumOptions[name] = optionValue;
         }
 
-        /// <summary>
-        /// Add new capabilities
-        /// </summary>
-        /// <param name="capabilityName">Capability name</param>
-        /// <param name="capabilityValue">Capabilities value, which cannot be null or empty</param>
-        [Obsolete("Use the the AddAdditionalAppiumOption method for adding additional options")]
-        public override void AddAdditionalCapability(string capabilityName, object capabilityValue)
-        {
-            this.AddAdditionalAppiumOption(capabilityName, capabilityValue);
-        }
-
         public override void AddAdditionalOption(string optionName, object optionValue)
         {
             throw new NotImplementedException("Use the the AddAdditionalAppiumOption method for adding additional options");

src/Appium.Net/Appium/Service/Options/OptionCollector.cs

@@ -68,7 +68,7 @@ public OptionCollector AddCapabilities(AppiumOptions options)
 
                 foreach (var item in result)
                 {
-                    this.options.AddAdditionalCapability(item.Key, item.Value);
+                    this.options.AddAdditionalAppiumOption(item.Key, item.Value);
                 }
             }
 

test/integration/ServerTests/StartingAppLocallyTest.cs

@@ -133,7 +133,7 @@ public void CheckThatServiseIsNotRunWhenTheCreatingOfANewSessionIsFailed()
                 ? //it will be a cause of error
                 Caps.GetAndroidUIAutomatorCaps(Apps.Get("androidApiDemos"))
                 : Caps.GetAndroidUIAutomatorCaps(Apps.Get("androidApiDemos"));
-            capabilities.AddAdditionalAppiumOption(MobileCapabilityType.DeviceName, "iPhone Simulator");
+            capabilities.DeviceName = "iPhone Simulator";
             capabilities.AddAdditionalAppiumOption(MobileCapabilityType.PlatformName, MobilePlatform.IOS);
 
             var builder = new AppiumServiceBuilder();